Replace eslint-config-standard-with-typescript with eslint-config-love #196
Conversation
tautschnig
commented
Dec 17, 2025
tautschnig
commented
- Removed deprecated eslint-config-standard-with-typescript from devDependencies
- Added [email protected] to devDependencies
- Updated TypeScript ESLint packages to v7.18.0 for compatibility
- Updated ESLint to v8.57.1
- Updated .eslintrc.js to extend 'love' configuration
- Added overrides for rules to maintain existing code style
- Added npm override for minimatch to fix type compatibility issues
- Updated @types/glob to v8.1.0
- Verified linting and compilation work correctly
- Removed deprecated eslint-config-standard-with-typescript from devDependencies - Added [email protected] to devDependencies - Updated TypeScript ESLint packages to v7.18.0 for compatibility - Updated ESLint to v8.57.1 - Updated .eslintrc.js to extend 'love' configuration - Added overrides for rules to maintain existing code style - Added npm override for minimatch to fix type compatibility issues - Updated @types/glob to v8.1.0 - Verified linting and compilation work correctly
|
We are still getting this error: It seems we should disable the "Default setup" in "Code Scanning" |
Ack, I'm still trying to figure out how to do this... |
|
This #197 should fix the CodeQL issue @tautschnig |
There was a problem hiding this comment.
Pull request overview
This PR migrates from the deprecated eslint-config-standard-with-typescript to eslint-config-love as the base ESLint configuration for the TypeScript project. The migration includes upgrading TypeScript ESLint packages from v5 to v7, updating ESLint, and adding rule overrides to maintain compatibility with the existing codebase.
Key Changes:
- Replaced deprecated [email protected] with [email protected]
- Upgraded @typescript-eslint packages from v5.31.0 to v7.18.0
- Added minimatch override and @types/minimatch to resolve type compatibility issues
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Removed deprecated package, added eslint-config-love, upgraded TypeScript ESLint packages to v7.18.0, ESLint to v8.57.1, added minimatch override and @types/minimatch |
| .eslintrc.js | Simplified extends array to use 'love' config, removed explicit import plugin configs, added 20 new rule overrides to maintain backward compatibility |
| package-lock.json | Updated lockfile with new dependency versions and transitive dependencies from upgraded packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "typescript": "^5.7.3" | ||
| }, | ||
| "overrides": { | ||
| "minimatch": "^5.1.6" |
There was a problem hiding this comment.
The minimatch override is set to "^5.1.6" which resolves to version 5.x, but @typescript-eslint/typescript-estree (v7.18.0) has a peer dependency requiring "minimatch": "^9.0.4" as seen in the package-lock.json. This version mismatch could lead to type compatibility issues or unexpected behavior. Consider updating the override to "^9.0.4" to match the expected peer dependency version, or verify that version 5.1.6 is sufficient for the actual use case.
| "minimatch": "^5.1.6" | |
| "minimatch": "^9.0.4" |
| 'plugin:@typescript-eslint/eslint-recommended', | ||
| 'plugin:@typescript-eslint/recommended-requiring-type-checking', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'love', |
There was a problem hiding this comment.
The extends array has been simplified by replacing multiple explicit TypeScript ESLint configurations with 'love', which is a curated ESLint config. However, the 'plugin:import/recommended' and 'plugin:import/typescript' configurations have been removed from the extends array. Since eslint-config-love doesn't include these import plugin configurations by default, you may need to verify that import-related rules are still functioning as expected, especially since the codebase has import ordering rules configured (lines 90-109).
| 'love', | |
| 'love', | |
| 'plugin:import/recommended', | |
| 'plugin:import/typescript', |
2 participants
