Skip to content

Replace eslint-config-standard-with-typescript with eslint-config-love #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tautschnig merged 2 commits into from
Dec 18, 2025
Merged

Replace eslint-config-standard-with-typescript with eslint-config-love #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc92162
Replace eslint-config-standard-with-typescript with eslint-config-love
Copilot Dec 17, 2025
84e7ec0
Merge branch 'main' into replace-eslint-config
tautschnig Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,8 @@ module.exports = {
},
plugins: ['@typescript-eslint', 'header', 'no-null', 'eslint-plugin-tsdoc', 'prettier'],
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:@typescript-eslint/recommended',
'love',
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extends array has been simplified by replacing multiple explicit TypeScript ESLint configurations with 'love', which is a curated ESLint config. However, the 'plugin:import/recommended' and 'plugin:import/typescript' configurations have been removed from the extends array. Since eslint-config-love doesn't include these import plugin configurations by default, you may need to verify that import-related rules are still functioning as expected, especially since the codebase has import ordering rules configured (lines 90-109).

Suggested change
'love',
'love',
'plugin:import/recommended',
'plugin:import/typescript',

Copilot uses AI. Check for mistakes.
'prettier',
'plugin:import/recommended',
'plugin:import/typescript',
],
rules: {
curly: 2,
Expand Down Expand Up @@ -58,6 +53,27 @@ module.exports = {
'@typescript-eslint/explicit-module-boundary-types': 'off',
'no-constant-condition': ['error', { checkLoops: false }],
'no-empty': 'off',
// Additional overrides for eslint-config-love compatibility
// These rules are disabled to maintain backward compatibility with the existing codebase
// and prevent unnecessary code changes during the migration from eslint-config-standard-with-typescript
'@typescript-eslint/naming-convention': 'off',
'@typescript-eslint/strict-boolean-expressions': 'off',
'@typescript-eslint/consistent-type-imports': 'off',
'@typescript-eslint/array-type': 'off',
'@typescript-eslint/no-base-to-string': 'off',
'@typescript-eslint/promise-function-async': 'off',
'@typescript-eslint/prefer-promise-reject-errors': 'off',
'@typescript-eslint/return-await': 'off',
'@typescript-eslint/prefer-optional-chain': 'off',
'@typescript-eslint/lines-between-class-members': 'off',
'@typescript-eslint/no-confusing-void-expression': 'off',
'eqeqeq': 'off',
'object-shorthand': 'off',
'no-useless-return': 'off',
'no-template-curly-in-string': 'off',
'@typescript-eslint/prefer-nullish-coalescing': 'off',
'@typescript-eslint/prefer-readonly': 'off',
'@typescript-eslint/method-signature-style': 'off',
'sort-imports': [
'error',
{
Expand Down
Loading
Loading