Skip to content

Resource subscribe should be true if handler provided #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PederHP
Copy link
Collaborator

@PederHP PederHP commented Aug 5, 2025

Motivation and Context

This is an old todo. Resource subscription is now supported and the handler is registered in the same file.

How Has This Been Tested?

Not yet, soon.

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@PederHP PederHP requested a review from halter73 August 5, 2025 19:29
@PederHP
Copy link
Collaborator Author

PederHP commented Aug 5, 2025

This should fix #656 I believe.

@PederHP PederHP marked this pull request as draft August 5, 2025 19:35
@PederHP PederHP changed the title Resource subscription is now supported Resource subscribe should be true if handler provided Aug 5, 2025
@PederHP PederHP marked this pull request as ready for review August 5, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants