Skip to content

Resource subscribe should be true if handler provided #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/ModelContextProtocol/McpServerHandlers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,13 @@
resourcesCapability.ListResourceTemplatesHandler = ListResourceTemplatesHandler ?? resourcesCapability.ListResourceTemplatesHandler;
resourcesCapability.ListResourcesHandler = ListResourcesHandler ?? resourcesCapability.ListResourcesHandler;
resourcesCapability.ReadResourceHandler = ReadResourceHandler ?? resourcesCapability.ReadResourceHandler;
}

if (SubscribeToResourcesHandler is not null || UnsubscribeFromResourcesHandler is not null)
{
resourcesCapability.SubscribeToResourcesHandler = SubscribeToResourcesHandler ?? resourcesCapability.SubscribeToResourcesHandler;
resourcesCapability.UnsubscribeFromResourcesHandler = UnsubscribeFromResourcesHandler ?? resourcesCapability.UnsubscribeFromResourcesHandler;
resourcesCapability.Subscribe = true;
}
if (SubscribeToResourcesHandler is not null || UnsubscribeFromResourcesHandler is not null)
{
resourcesCapability.SubscribeToResourcesHandler = SubscribeToResourcesHandler ?? resourcesCapability.SubscribeToResourcesHandler;

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Release)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Debug)

Dereference of a possibly null reference.

Check failure on line 192 in src/ModelContextProtocol/McpServerHandlers.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Debug)

Dereference of a possibly null reference.
resourcesCapability.UnsubscribeFromResourcesHandler = UnsubscribeFromResourcesHandler ?? resourcesCapability.UnsubscribeFromResourcesHandler;
resourcesCapability.Subscribe = true;
}

ToolsCapability? toolsCapability = options.Capabilities?.Tools;
Expand Down
Loading