Add comprehensive test coverage for resource capability preservation with WithResources #896
+242
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive test coverage for the scenario reported in issue #XXX where users manually set resource capabilities (e.g.,
Subscribe = true
) and then useWithResources<T>()
to register resources.Background
The issue reported that when declaring support for resource notifications via manual capability configuration:
The resources added using
WithResources
were not being exposed to the client.Investigation
After thorough investigation and testing, I found that this functionality is already working correctly in the current codebase. The manual capability settings are properly preserved by
McpServerOptionsSetup
, and resources are correctly exposed to clients.Changes
Added 6 new tests across 2 test files:
Unit Tests (
McpServerOptionsSetupTests.cs
)McpServerOptions
when usingWithResources
ResourceCollection
even when capabilities are manually configuredIntegration Tests (
McpServerResourceCapabilityIntegrationTests.cs
)Test Results
All tests pass (799 total tests), confirming that:
WithResources
Subscribe
capability is correctly advertised to clients when manually configuredConclusion
The reported issue does not reproduce in the current codebase, suggesting it may have been fixed in a previous commit or requires a specific scenario not yet identified (possibly related to
WithHttpTransport()
combined withWithSubscribeToResourcesHandler()
as mentioned in the related issue #656).These tests provide valuable documentation of the expected behavior and ensure this functionality remains correct in future changes.
Fixes #XXX
Original prompt
Fixes #650
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.