internal/oauthex: add dynamic client registration #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samthanawalla
requested review from
rolandshoemaker
and removed request for
findleyr
jba
requested changes
Sep 24, 2025
samthanawalla
force-pushed
the
oauthDCR
branch
from
ef5aeee to
d4ee5e9
Compare
jba
requested changes
Sep 25, 2025
internal/oauthex/auth_meta.go
Outdated
|
|
||
| // ClientIDIssuedAt is an OPTIONAL timestamp (seconds from 1970 UTC) when | ||
| // the ClientID was issued. | ||
| ClientIDIssuedAt int64 `json:"client_id_issued_at,omitempty"` |
Contributor
There was a problem hiding this comment.
Let's make this and the following time.Times.
It's not too hard to write custom Marshal/UnmarshalJSON methods, using tricks like the one at https://cs.opensource.google/go/x/oauth2/+/refs/tags/v0.31.0:deviceauth.go;l=42.
Contributor
Author
There was a problem hiding this comment.
Done. Hope I did it correctly!
jba
previously approved these changes
Sep 25, 2025
internal/oauthex/auth_meta.go
Outdated
| ClientSecretExpiresAt time.Time `json:"client_secret_expires_at,omitempty"` | ||
| } | ||
|
|
||
| func (r ClientRegistrationResponse) MarshalJSON() ([]byte, error) { |
jba
approved these changes
Sep 25, 2025
appleboy
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements https://www.rfc-editor.org/rfc/rfc7591.html
See https://github.com/modelcontextprotocol/typescript-sdk/blob/main/src/client/auth.ts as a reference.
For #493