Add a toast on connection error #765
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When failing to connect to an MCP server, its very hard to understand why. There is only an opaque "Connection Error" message with no additional info. This also doesn't change at all on repeated attempts, so there is no indication we attempted again and failed. This change introduces a `toast` to visualize the error, and adds the `cause` into the error message for further debugging
cliffhall
requested changes
Oct 10, 2025
There was a problem hiding this comment.
Hi @howardjohn,
Thanks for this, just want to request a small fix for toast behavior.
| title: "Connection error", | ||
| description: `Connection failed: "${e}"`, | ||
| variant: "destructive", | ||
| }); |
There was a problem hiding this comment.
If that conditional toast above this is fired, there will be a second toast popped about a connection error. It should be an if/else.
Suggested change
| }); | |
| } else { | |
| toast({ | |
| title: "Connection error", | |
| description: `Connection failed: "${e}"`, | |
| variant: "destructive", | |
| }); | |
| } |
cliffhall
added
the
waiting on submitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When failing to connect to an MCP server, its very hard to understand why. There is only an opaque "Connection Error" message with no additional info. This also doesn't change at all on repeated attempts, so there is no indication we attempted again and failed.
This change introduces a
toastto visualize the error, and adds thecauseinto the error message for further debuggingHow Has This Been Tested?
Manually tested
Breaking Changes
No
Types of changes
Checklist
Additional context