Skip to content

Add a toast on connection error #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −1
Open

Add a toast on connection error #765

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f54f2ec
Add a toast on connection error
howardjohn Aug 28, 2025
9572b87
Merge branch 'main' into inspector/error-popup
howardjohn Sep 4, 2025
7f4b3c5
Merge branch 'main' into inspector/error-popup
cliffhall Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client/src/lib/hooks/useConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,11 @@ export function useConnection({
variant: "destructive",
});
}
toast({
title: "Connection error",
description: `Connection failed: "${e}"`,
variant: "destructive",
});
Copy link
Member

@cliffhall cliffhall Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that conditional toast above this is fired, there will be a second toast popped about a connection error. It should be an if/else.

Suggested change
});
} else {
toast({
title: "Connection error",
description: `Connection failed: "${e}"`,
variant: "destructive",
});
}

console.error(e);
setConnectionStatus("error");
}
Expand Down
4 changes: 3 additions & 1 deletion server/src/mcpProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ export default function mcpProxy({
id: message.id,
error: {
code: -32001,
message: error.message,
message: error.cause
? `${error.message} (cause: ${error.cause})`
: error.message,
data: error,
},
};
Expand Down