refactor: deprecate remaining HttpServletSseServerTransportProvider constructor #523
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstructor Complete constructor deprecation from commit 1840f63 addressing potential oversight during initial refactoring Related to: 1840f63, PR modelcontextprotocol#430
ParanoidUser
force-pushed
the
deprecate-remaining-transport-constructor
branch
from
94a0cbd to
9d3054b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahoy @tzolov! 👋
Motivation and Context
This adds the missing
@Deprecatedannotation to complete the builder pattern migration started in PR #430.How Has This Been Tested?
Breaking Changes
No breaking changes. Constructor is still available, but marked deprecated.
Types of changes
Checklist
Additional context
If the overall goal is to have a single way to create all transport providers via builders,
StdioServerTransportProvidermight be another candidate that needs some cleanup. I'm open to adding a builder and deprecating constructors if it makes sense.