Skip to content

refactor: deprecate remaining HttpServletSseServerTransportProvider constructor #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −11
Open

refactor: deprecate remaining HttpServletSseServerTransportProvider constructor #523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3054b
refactor: deprecate remaining HttpServletSseServerTransportProvider c…
ParanoidUser Aug 28, 2025
349cb60
Merge branch 'main' into deprecate-remaining-transport-constructor
ParanoidUser Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions .../java/io/modelcontextprotocol/server/transport/HttpServletSseServerTransportProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,20 @@ public class HttpServletSseServerTransportProvider extends HttpServlet implement
*/
private KeepAliveScheduler keepAliveScheduler;

/**
* Creates a new HttpServletSseServerTransportProvider instance with the default SSE
* endpoint.
* @param objectMapper The JSON object mapper to use for message
* serialization/deserialization
* @param messageEndpoint The endpoint path where clients will send their messages
* @deprecated Use the builder {@link #builder()} instead for better configuration
* options.
*/
@Deprecated
public HttpServletSseServerTransportProvider(ObjectMapper objectMapper, String messageEndpoint) {
this(objectMapper, messageEndpoint, DEFAULT_SSE_ENDPOINT);
}

/**
* Creates a new HttpServletSseServerTransportProvider instance with a custom SSE
* endpoint.
Expand Down Expand Up @@ -218,17 +232,6 @@ public List<String> protocolVersions() {
return List.of(ProtocolVersions.MCP_2024_11_05);
}

/**
* Creates a new HttpServletSseServerTransportProvider instance with the default SSE
* endpoint.
* @param objectMapper The JSON object mapper to use for message
* serialization/deserialization
* @param messageEndpoint The endpoint path where clients will send their messages
*/
public HttpServletSseServerTransportProvider(ObjectMapper objectMapper, String messageEndpoint) {
this(objectMapper, messageEndpoint, DEFAULT_SSE_ENDPOINT);
}

/**
* Sets the session factory for creating new sessions.
* @param sessionFactory The session factory to use
Expand Down