MCP Schema #378
Open
MCP Schema #378
+13,146
−2,448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpavlov
previously approved these changes
Nov 7, 2025
| name: String, | ||
| description: String, | ||
| inputSchema: Tool.Input = Tool.Input(), | ||
| inputSchema: ToolSchema = ToolSchema(), |
| get() = _responseHandlers.value | ||
|
|
||
| private val _progressHandlers: AtomicRef<PersistentMap<RequestId, ProgressCallback>> = | ||
| private val _progressHandlers: AtomicRef<PersistentMap<ProgressToken, ProgressCallback>> = |
|
|
||
| setRequestHandler<PingRequest>(Method.Defined.Ping) { _, _ -> | ||
| EmptyRequestResult() | ||
| EmptyResult() |
devcrocod
force-pushed
the
devcrocod/mcp-schema
branch
from
6b2f4ad to
55214b8
Compare
devcrocod
force-pushed
the
devcrocod/mcp-schema
branch
from
55214b8 to
4f0decc
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Kotlin SDK's type system by moving MCP protocol types from the io.modelcontextprotocol.kotlin.sdk package to a new io.modelcontextprotocol.kotlin.sdk.types package. This is a large-scale package reorganization that affects both the core SDK and test code.
Key changes:
- Moved all protocol types (requests, responses, notifications, etc.) to a dedicated
typespackage - Updated all import statements across test files to reference the new package location
- Renamed several classes to improve clarity (e.g.,
Tool.Input→ToolSchema,EmptyRequestResult→EmptyResult) - Restructured test files to align with the new package structure, creating dedicated test files for each type category
Reviewed Changes
Copilot reviewed 93 out of 95 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Multiple test files in kotlin-sdk-test/src/jvmTest/ |
Updated imports from io.modelcontextprotocol.kotlin.sdk.* to io.modelcontextprotocol.kotlin.sdk.types.* |
Multiple test files in kotlin-sdk-core/src/commonTest/ |
Created new comprehensive test files organized by type category (ToolsTest, SamplingTest, etc.) and updated existing tests |
| Server implementation files | Updated imports and references to use new type package location |
| Transport and shared infrastructure | Updated to reference types from new package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the last version of the mcp schema and complete restructuring of the mcp schema implementation from a monolithic
types.ktfile into separate files.Motivation and Context
The previous implementation of the mcp schema was outdated and contained several issues. In addition, it stored all mcp types in a single large file, which made maintenance and further development more difficult
How Has This Been Tested?
All tests passed
Breaking Changes
Yes. The new types are now located in a separate package. Additionally, many types have new parameters and modified constructors
Types of changes
Checklist
Additional context
to adopt the new structure:
Before:
After: