Skip to content

Conversation

@chr-hertel
Copy link
Member

@chr-hertel chr-hertel commented Aug 3, 2025

Okay, this was freaky easy. Celebrated too early.

Refactored the relation between Notification and Request base classes and their children
was quite implicit coupling but serving to concern - moved the schema upcasting (e.g. fromNotification()) and the method check to Mcp\Message\Factory

Reworked the relation between handler, schema and what will become the registries again. next step.

@chr-hertel chr-hertel force-pushed the adopt-schema branch 2 times, most recently from b33cec3 to cd10995 Compare August 3, 2025 20:23
@chr-hertel
Copy link
Member Author

there's another push incoming for replacing the VOs in Mcp\Capability\

@CodeWithKyrian
Copy link
Contributor

This is solid overall.

I noticed the move to class-level readonly and was going to comment, but then I checked the minimum supported PHP version and it's 8.2 so that's fine.

Curious though, is there any particular reason for going with 8.2 as the minimum and not, say... 8.1?

@chr-hertel
Copy link
Member Author

PHP 8.1 is still officially supported, that's true - it's only another three months or so and packagist.org claims it is only 12% right now. If you care, we can keep 8.1, but I didn't since this is quite new code 🙊

@CodeWithKyrian
Copy link
Contributor

Fair enough 😅 I totally get that.

For me, I just like to support as many PHP setups as possible (especially within the same major version). But yeah, we could also decide to make this one of those "you-must-upgrade" packages and help push people off 8.1 entirely. So it’s really a matter of vibe - do we want to be accommodators or enforcers? 😂 (What's Symfony's in this case?)

Either way works for me tbh.

@chr-hertel
Copy link
Member Author

Well, Symfony has usually quite long support ranges with the LTS versions, but higher versions on recent versions:

  • Legacy LTS v5.4 => Support until beginning of 2029 => PHP 7.2
  • Current LTS v6.4 => Support until end of 2027 => PHP 8.1
  • Current Minor 7.3 => Support until beginning of 2026 => PHP 8.2

So, I'd say you have a good point here 😆
Let's keep Symfony 6.4 compatibility basically - can't do PHP 7.2 without crying

@CodeWithKyrian
Copy link
Contributor

Nahhh. 7.2 is off the table!!!!

@chr-hertel chr-hertel force-pushed the schema branch 3 times, most recently from 91bc19c to 0c6d7bf Compare August 5, 2025 20:47
@chr-hertel chr-hertel force-pushed the adopt-schema branch 3 times, most recently from 3c5bb7a to f7dad93 Compare August 5, 2025 21:17
@chr-hertel chr-hertel force-pushed the adopt-schema branch 2 times, most recently from d7ea5db to 29c5a85 Compare August 5, 2025 21:22
@chr-hertel chr-hertel force-pushed the adopt-schema branch 4 times, most recently from 079a4be to e111278 Compare August 8, 2025 20:56
@chr-hertel chr-hertel marked this pull request as ready for review August 8, 2025 20:58
@chr-hertel
Copy link
Member Author

Got merged into main with 09707b4

@chr-hertel chr-hertel deleted the adopt-schema branch August 29, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants