-
Notifications
You must be signed in to change notification settings - Fork 81
Adopt Schema component in server handlers #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b33cec3 to
cd10995
Compare
|
there's another push incoming for replacing the VOs in |
|
This is solid overall. I noticed the move to class-level readonly and was going to comment, but then I checked the minimum supported PHP version and it's 8.2 so that's fine. Curious though, is there any particular reason for going with 8.2 as the minimum and not, say... 8.1? |
|
PHP 8.1 is still officially supported, that's true - it's only another three months or so and packagist.org claims it is only 12% right now. If you care, we can keep 8.1, but I didn't since this is quite new code 🙊 |
|
Fair enough 😅 I totally get that. For me, I just like to support as many PHP setups as possible (especially within the same major version). But yeah, we could also decide to make this one of those "you-must-upgrade" packages and help push people off 8.1 entirely. So it’s really a matter of vibe - do we want to be accommodators or enforcers? 😂 (What's Symfony's in this case?) Either way works for me tbh. |
|
Well, Symfony has usually quite long support ranges with the LTS versions, but higher versions on recent versions:
So, I'd say you have a good point here 😆 |
|
Nahhh. 7.2 is off the table!!!! |
cd10995 to
ef9f562
Compare
91bc19c to
0c6d7bf
Compare
3c5bb7a to
f7dad93
Compare
f7dad93 to
2ba07ab
Compare
d7ea5db to
29c5a85
Compare
079a4be to
e111278
Compare
e111278 to
64af4e7
Compare
64af4e7 to
09707b4
Compare
|
Got merged into main with 09707b4 |
Okay, this was freaky easy.Celebrated too early.Refactored the relation between
NotificationandRequestbase classes and their childrenwas quite implicit coupling but serving to concern - moved the schema upcasting (e.g.
fromNotification()) and the method check toMcp\Message\FactoryReworked the relation between handler, schema and what will become the registries again. next step.