Skip to content

Ensure failed oauth registration response is read before accessing response.text #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Ensure failed oauth registration response is read before accessing response.text #1118

merged 2 commits into from
Jul 10, 2025

Conversation

@jlowin
Copy link
Contributor

@jlowin jlowin commented Jul 10, 2025 •
edited
Loading

A minor fix - this condition attempts to access response.text before the response has been read, which raises an httpx error. Discovered while investigating jlowin/fastmcp#1111

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

ihrpr
ihrpr previously approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ihrpr ihrpr merged commit 81fe63a into modelcontextprotocol:main Jul 10, 2025
28 of 30 checks passed
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
@jlowin @ihrpr @saqadri
Ensure failed oauth registration response is read before accessing re…
bcea357 
…sponse.text (modelcontextprotocol#1118)

Co-authored-by: ihrpr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihrpr ihrpr ihrpr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jlowin @ihrpr