Skip to content

Ensure failed oauth registration response is read before accessing response.text #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Ensure failed oauth registration response is read before accessing response.text #1118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa4e0b
Ensure the response is read before accessing response.text
jlowin Jul 10, 2025
a24d3d1
add test
ihrpr Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/mcp/client/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ async def _register_client(self) -> httpx.Request | None:
async def _handle_registration_response(self, response: httpx.Response) -> None:
"""Handle registration response."""
if response.status_code not in (200, 201):
await response.aread()
raise OAuthRegistrationError(f"Registration failed: {response.status_code} {response.text}")

try:
Expand Down
Loading