Skip to content

fix: error too many values to unpack (expected 2) #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sandangel
Copy link

@sandangel sandangel commented Aug 17, 2025

Signed-off-by: San Nguyen [email protected]

Motivation and Context

The parse_qs function return dictionary, and will have to use .items() with for loop

How Has This Been Tested?

redirect_uri_base = "http://localhost:8000/callback?session_id=1234"

parsed_uri = urlparse(redirect_uri_base)

for k, vs in parse_qs(parsed_uri.query):
    print(f"{k}: {vs}")

This will throw error

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: too many values to unpack (expected 2)

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@sandangel sandangel requested a review from a team as a code owner August 17, 2025 12:02
@sandangel sandangel requested a review from ochafik August 17, 2025 12:02
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please can tests be added to prevent regressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants