Skip to content

fix: error too many values to unpack (expected 2) #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2025
Merged

fix: error too many values to unpack (expected 2) #1279

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0de0fb
fix: error too many values to unpack (expected 2)
sandangel Aug 17, 2025
6b0c825
test: add regression tests for construct_redirect_uri function
felixweinberger Aug 21, 2025
babfcd8
Merge branch 'main' into fix/error-too-many-values-to-unpack-expected-2
felixweinberger Aug 21, 2025
ccf669f
Merge branch 'main' into fix/error-too-many-values-to-unpack-expected-2
sandangel Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcp/server/auth/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ async def revoke_token(

def construct_redirect_uri(redirect_uri_base: str, **params: str | None) -> str:
parsed_uri = urlparse(redirect_uri_base)
query_params = [(k, v) for k, vs in parse_qs(parsed_uri.query) for v in vs]
query_params = [(k, v) for k, vs in parse_qs(parsed_uri.query).items() for v in vs]
for k, v in params.items():
if v is not None:
query_params.append((k, v))
Expand Down
Loading