fix: resolve registry image conflict in docker-compose #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: links directive was failing on podman - Removed unsupported 'links' directive for Podman compatibility
Contributor
Author
|
Please merge this or i do need to do anything else for merging. |
Contributor
|
Hi @toby , review complete, merge please 🙏 ! |
domdomegg
approved these changes
Aug 6, 2025
Member
domdomegg
left a comment
domdomegg
left a comment
There was a problem hiding this comment.
(reapproving after fixing merge conflicts)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
domdomegg
added a commit
that referenced
this pull request
Aug 7, 2025
Issue: links directive was failing on podman - Removed unsupported 'links' directive for Podman compatibility <!-- Provide a brief summary of your changes --> It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file. ## Motivation and Context docker-compose -links deprecated #107 Fix the defect by removing link. ## How Has This Been Tested? Yes. Test by running on both. For Docker run. docker build -t registry . docker compose up For Podman podman build -t registry . podman compose up ## Breaking Changes Yes for podman. ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ x] My code follows the repository's style guidelines - [ x] New and existing tests pass locally - [ x] I have added appropriate error handling - [x ] I have added or updated documentation as needed ## Additional context It is related to issue #107 Co-authored-by: Avinash Sridhar <[email protected]> Co-authored-by: adam jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: links directive was failing on podman
It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file.
Motivation and Context
docker-compose -links deprecated #107
Fix the defect by removing link.
How Has This Been Tested?
Yes. Test by running on both.
For Docker run.
docker build -t registry .
docker compose up
For Podman
podman build -t registry .
podman compose up
Breaking Changes
Yes for podman.
Types of changes
Checklist
Additional context
It is related to issue #107