Skip to content

Conversation

web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Dec 24, 2024

What I did

  1. Upgraded webdriverio to v9 and changed the saucelabs launcher accordingly
  2. Removed logic and docs related to JWP capabilities as these have been dropped

Note

Tested locally by running tests for @web/test-runner-webdriver package. These don't currently run in CI as they were skipped long ago, in particular due to webdriverio/selenium-standalone#788 - that issue is now fixed but unfortunately the fix landed in a version that dropped Node 18 support.

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: c8d8352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@web/test-runner-browserstack Minor
@web/test-runner-saucelabs Minor
@web/test-runner-webdriver Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@web-padawan web-padawan force-pushed the feat/wdio-v9 branch 5 times, most recently from fbc632d to 7203a0e Compare December 28, 2024 10:11
Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Two questions and then likely good to go.


function getPlatform(c: WebDriver.DesiredCapabilities): string | undefined {
return c.platformName || c.platform;
function getPlatform(c: WebdriverIO.Capabilities): string | undefined {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this file get this type value from? If it works, it works, but confused that there is no import. The main question is if we're doing something special somewhere else, or relying on something that I can't see, then is it visible to a more experienced WebdriverIO user in a way that would prevent their consumption of this from causing them issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use this but got error "Cannot use namespace 'Capabilities' as a type".

import type { Capabilities } from '@wdio/types';

The namespace is defined here, seems like it's done for supporting custom capabilities.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it run fine in other projects this way. I'm fine with whatever works, it was just surprising to see and would be annoying if this caused some undocumented requirements on consumers.

# Conflicts:
#	package-lock.json
@bashmish bashmish merged commit 9e36bb5 into master Jan 27, 2025
5 of 9 checks passed
@bashmish bashmish deleted the feat/wdio-v9 branch January 27, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants