Skip to content

Comments

TEST-#7643: Fix residual failures from pandas 2.3#7644

Merged
sfc-gh-joshi merged 3 commits intomodin-project:mainfrom
sfc-gh-joshi:joshi/fix-main-ci
Aug 7, 2025
Merged

TEST-#7643: Fix residual failures from pandas 2.3#7644
sfc-gh-joshi merged 3 commits intomodin-project:mainfrom
sfc-gh-joshi:joshi/fix-main-ci

Conversation

@sfc-gh-joshi
Copy link
Contributor

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves TEST: CI is broken at main #7643
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

2 failures are fixed here:

  • DataFrame.insert apparently is now typed with pandas-stubs==2.3, but was not typed before. Since pandas 2.3 is compatible with Python 3.9 all CI runs should pick up this change, but if it continues to be an issue I'll look into a workaround for seeing if it's possible to conditionally add the type: ignore directive.
  • np.cumproduct was deprecated some time ago, and removed in numpy>2. We've supported numpy>2 for a while, so it's unclear why this issue only just triggered.

Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
@sfc-gh-joshi sfc-gh-joshi merged commit 6504ed3 into modin-project:main Aug 7, 2025
40 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi/fix-main-ci branch August 7, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TEST: CI is broken at main

2 participants