-
-
Notifications
You must be signed in to change notification settings - Fork 357
feat(nextjs-mf): RSC Support #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ScriptedAlchemy
wants to merge
116
commits into
pr9-implementation
Choose a base branch
from
share-filter
base: pr9-implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
746536d
chore: add test for filter
ScriptedAlchemy de9072f
feat(enhanced): add filter option for shared modules
ScriptedAlchemy 81b5d1e
feat(enhanced): add filter test
ScriptedAlchemy 562221d
chore: restore tests
ScriptedAlchemy 0a93219
chore: restore tests
ScriptedAlchemy 10ba6fa
chore: restore tests
ScriptedAlchemy 6683ff1
fix(enhanced): update share plugin schema
ScriptedAlchemy 56d0909
feat(enhanced): exclude shares by semver (#3744)
ScriptedAlchemy 9f784bc
chore: remove log in test
ScriptedAlchemy 86f7740
docs: add sharing documentation
ScriptedAlchemy 8d9730e
docs: add tests back
ScriptedAlchemy 44110a5
test: add consume share plugin compiler tests
ScriptedAlchemy 62d4150
test: add consume share plugin compiler tests
ScriptedAlchemy ce95954
test: add consume share plugin compiler tests
ScriptedAlchemy 36aa95b
test: add comprehensive tests for ConsumeSharedPlugin with layer hand…
ScriptedAlchemy 5f815d2
chore: locks
ScriptedAlchemy 8bf47a6
fix: update tests for provide shared
ScriptedAlchemy d39c63c
chore: lint
ScriptedAlchemy 6cd3102
feat: add singleton validation warnings for include/exclude
ScriptedAlchemy 5334e5d
chore: remove implicit dep
ScriptedAlchemy 716d834
chore: changeset
ScriptedAlchemy b209de8
chore: nx mcp
ScriptedAlchemy cfeeacb
chore(3001-shop): sync project.json serve parallel and e2e logic
ScriptedAlchemy 74f9164
chore: locks
ScriptedAlchemy 10c072a
chore: locks
ScriptedAlchemy 4dcfe73
chore: add missing next deps
ScriptedAlchemy cdbe61a
chore: update cmd syntax exit
ScriptedAlchemy 7d2fd2a
chore: update cmd syntax exit
ScriptedAlchemy 92f1b2f
chore: update cmd syntax exit
ScriptedAlchemy e073b0a
chore: update cmd syntax exit
ScriptedAlchemy 2838a51
chore: update cmd syntax exit
ScriptedAlchemy 7e4a624
chore: update cmd syntax exit
ScriptedAlchemy 5a3fdc6
chore: refactor E2E testing workflow to separate tests for each app a…
ScriptedAlchemy be727a5
chore: locks
ScriptedAlchemy 623b7c1
test: update ProvideSharedPlugin and SharePlugin tests to verify node…
ScriptedAlchemy 30b5f89
chore: update Nx version to 21.0.3 and change package manager to pnpm…
ScriptedAlchemy cff3627
feat: integrate Module Federation core sharing plugin updates
ScriptedAlchemy ea5ef51
feat: complete incremental Module Federation ProvideSharedPlugin updates
ScriptedAlchemy 6a150b3
feat(enhanced): add nodeModulesReconstructedLookup support
ScriptedAlchemy 372b9ed
feat(enhanced): remove complex singleton warnings from factorize hook
ScriptedAlchemy fe28325
docs: refresh mermaid diagrams and remove sections
ScriptedAlchemy 7d520e0
docs: remove Advanced Patterns & Use Cases section
ScriptedAlchemy 7d28536
fix: resolve Mermaid sequence diagram CSP participant activation/deac…
ScriptedAlchemy af21d0f
chore: no build cache nx in ci
ScriptedAlchemy 5595721
chore: ci
ScriptedAlchemy 26e594b
chore: ci
ScriptedAlchemy e8ddfa2
feat(enhanced): update hook system for container dependency management
ScriptedAlchemy c2138b2
feat(nextjs-mf): complete migration from app-router-share-filter to s…
ScriptedAlchemy 81b0331
fix(enhanced): add CI stability improvements to jest configurations
ScriptedAlchemy f0d322f
fix(enhanced): resolve jest maxWorkers validation error
ScriptedAlchemy f663d7f
fix(enhanced): restore jest configurations to original state
ScriptedAlchemy 754845c
feat(nextjs-mf): rewrite outdated tests with proper mocks
ScriptedAlchemy 1bf1276
fix(nextjs-mf): simplify tests to eliminate interference issues
ScriptedAlchemy 5957304
feat: update e2e scripts to test all three Next.js apps (home, shop, …
ScriptedAlchemy 9bc80b5
feat: add individual e2e test scripts for Next.js apps
ScriptedAlchemy 38e3155
feat: incremental merge of share-filter branch changes (#3879)
ScriptedAlchemy 6f911c1
chore: remove rslib
ScriptedAlchemy 0c0c295
chore: remove rslib
ScriptedAlchemy 6d26aa0
feat(nextjs-mf): increment 1 - migrate enhanced test file from app-ro…
ScriptedAlchemy de8ffdb
fix(nextjs-mf): fix failing internal tests by mocking Next.js version
ScriptedAlchemy 3959bc8
chore: restore rslib module app
ScriptedAlchemy aeb8b77
feat: sync all Next.js versions to 15.3.3 and enable remote components
ScriptedAlchemy 314a22b
chore: lock file
ScriptedAlchemy c3c6187
fix: resolve React 19 TypeScript compatibility in chrome-devtools
ScriptedAlchemy 3f3dd49
fix(managers): update snapshot for React 19 compatibility
ScriptedAlchemy 8e39ee4
fix: resolve React version conflicts in Next.js apps
ScriptedAlchemy 39908a4
fix: add safety checks for webpack startup functions
ScriptedAlchemy 6b23f8f
chore: lock file
ScriptedAlchemy 51d8a61
fix: update SharedManager snapshot for React 19.1.0
ScriptedAlchemy ab341d4
fix(data-prefetch): react 19 compatibility fixes
ScriptedAlchemy 9990c08
fix(data-prefetch): update pnpm lockfile after react 19 upgrade
ScriptedAlchemy 18b827d
fix(bridge-react): react 19 compatibility for tests
ScriptedAlchemy fdea9ae
fix(bridge-react): update tests to handle React 19 async rendering
ScriptedAlchemy 177c822
feat: merge increment A - CI/CD and development infrastructure
ScriptedAlchemy 29d5e3c
chore: update pnpm lockfile after increment A package.json changes
ScriptedAlchemy 23cf673
feat: merge increment B - documentation and changesets
ScriptedAlchemy 74c2c53
feat: merge increment C - core package dependencies
ScriptedAlchemy 9fa2ab5
feat: merge increment D - enhanced library core changes
ScriptedAlchemy 9dccd37
fix: resolve React 19 TypeScript compatibility in modernjs package
ScriptedAlchemy 21e5634
fix(nextjs-mf): resolve test failure by mocking getNextVersion for Ne…
ScriptedAlchemy c47d4df
feat: merge increment E - bridge and data prefetch updates
ScriptedAlchemy d53dc6d
fix: update React dependencies to v19.0.0 across packages
ScriptedAlchemy 1f015a4
fix: update React dependencies to v19.0.0 across packages
ScriptedAlchemy ddcb1ed
fix: use pnpm overrides for React 19 instead of individual package edits
ScriptedAlchemy 98b5732
fix: update packages to React 19 individually instead of global overr…
ScriptedAlchemy 9f859fa
fix: resolve React 19 compatibility issues in bridge-react
ScriptedAlchemy 96f734e
fix: remove accidental __mocks__ files causing CI format failure
ScriptedAlchemy e1d4a34
fix(bridge-react): resolve React 19 testing warnings and race conditions
ScriptedAlchemy 8aef3aa
feat(next-app-router-4000): merge enhanced layer support for Next.js …
ScriptedAlchemy d8b2595
feat(next-app-router-4001): merge enhanced layer support for Next.js …
ScriptedAlchemy d76f505
feat(runtime-core,node): merge enhanced layer support for runtime and…
ScriptedAlchemy 9a0ef18
feat: complete enhanced layer support integration and add .node file …
ScriptedAlchemy d931787
fix: restore missing files from app-router-share-filter and remove te…
ScriptedAlchemy dfb51ad
fix: clean up remaining file differences and update dependencies
ScriptedAlchemy 168e3d0
fix(3001-shop,3002-checkout): restore workspace dependencies
ScriptedAlchemy 1c481a1
fix(nextjs-mf): correct path to next-flight-loader
ScriptedAlchemy ba75991
chore: lock file
ScriptedAlchemy fe26736
chore: fix sh
ScriptedAlchemy 83e8fad
fix(3000-home,3002-checkout): restore e2e configurations from working…
ScriptedAlchemy e2ed2e7
feat: restore old CI infrastructure for Next.js e2e tests
ScriptedAlchemy 276b05b
App router share filter (#3745)
ScriptedAlchemy e82398d
test: trigger CI workflow (#3890)
ScriptedAlchemy 95d0412
Potential fix for code scanning alert no. 132: Workflow does not cont…
ScriptedAlchemy ea1188b
Share flalback (#3893)
ScriptedAlchemy a6873a9
docs: add incremental PR plan for breaking up enhanced package changes
ScriptedAlchemy 2f5509a
docs: add incremental PR plan for breaking up enhanced package changes
ScriptedAlchemy 30f26c6
fix: include request warning logs in ProvideSharedPlugin (#3906)
adit-shah-devrev a66c266
chore: fix conflicts
ScriptedAlchemy e7a48b6
fix: resolve 500 Internal Server Error in 3002-checkout app
ScriptedAlchemy 5da76b9
chore: fix conflicts
ScriptedAlchemy 2061436
test: update error message expectations for loadShareSync
ScriptedAlchemy faea64e
feat: incremental merge of share-filter branch changes (#3879)
ScriptedAlchemy 055deac
Apply suggested changes
ScriptedAlchemy accbdad
chore: fix package conflicts
ScriptedAlchemy d9a89a4
chore: fix package conflicts
ScriptedAlchemy f9ec75f
Merge remote-tracking branch 'origin/pr9-implementation' into share-f…
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
"@module-federation/runtime-core": minor | ||
--- | ||
|
||
Added support for OR ranges in semantic version satisfaction logic with comprehensive unit tests. | ||
|
||
- Implemented parsing for OR (||) conditions in version ranges. | ||
- Split input ranges by || to evaluate alternatives individually. | ||
- Ensured logical handling of wildcards '*' and 'x' within ranges. | ||
- Refactored internal parsing to support more complex range constructs. | ||
- Added comprehensive test cases to cover diverse scenarios for OR range support. | ||
- Introduced error handling during range processing, with console logging for tracking issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
"@module-federation/nextjs-mf": minor | ||
--- | ||
|
||
Refactor and enhance module federation support for Next.js. | ||
|
||
- Introduced `getShareScope` function to dynamically generate the default share scope based on the client or server environment, replacing static DEFAULT_SHARE_SCOPE declarations. | ||
- Implemented `RscManifestInterceptPlugin` to intercept and modify client reference manifests, ensuring proper prefix handling. | ||
- Refined server-side externals handling to ensure shared federation modules are bundled. | ||
- Simplified and modularized sharing logic by creating distinct functions for React, React DOM, React JSX Runtime, and React JSX Dev Runtime package configurations. | ||
- Captured the original webpack public path for potential use in plugins and adjustments. | ||
- Enhanced logging for debug tracing of shared module resolution processes in runtimePlugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"@module-federation/sdk": minor | ||
--- | ||
|
||
Added a new option to improve path resolution in ModuleFederationPlugin options. | ||
|
||
- Introduced `nodeModulesReconstructedLookup` option in `ModuleFederationPluginOptions` | ||
- Enhances support for reconstructed lookup of node_modules paths | ||
- The new option is a boolean and is optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
"@module-federation/enhanced": minor | ||
--- | ||
|
||
Enhancements to layer handling in module federation tests and configuration. | ||
|
||
- Improved handling of `shareKey` for layers within `ConsumeSharedPlugin` and `ProvideSharedPlugin`. | ||
- Conditionally prepend the `shareKey` with the `layer` if applicable. | ||
- Introduced new layer configurations to support more nuanced federation scenarios that consider multiple layers of dependency. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
"@module-federation/enhanced": minor | ||
--- | ||
|
||
Add advanced sharing capabilities in Module Federation | ||
|
||
- Expanded `IncludeExcludeOptions` to support `request`, `version`, and `fallbackVersion` filters for finer control of module sharing inclusion and exclusion, allowing developers to target specific module versions or paths when sharing. | ||
- Enhanced the configuration of `ConsumeSharedModule`, `ConsumeSharedPlugin`, `ProvideSharedPlugin`, and `SharePlugin` to leverage these filtering options. | ||
- Implemented new experimental features under `experiments`: `nodeModulesReconstructedLookup`, enabling more robust and flexible path reconstructions when consuming or providing shared modules, thus improving compatibility with monorepos and complex project structures. | ||
- Updated internal schema validation and error handling to provide more informative feedback and operational resilience against misconfigurations or missing information. | ||
- Introduced comprehensive test coverage for new features and plugin behaviors, ensuring robust validation against various edge cases and scenarios within module sharing operations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"@module-federation/enhanced": patch | ||
--- | ||
|
||
Refactored module sharing configuration handling. | ||
|
||
- Simplified plugin schema for better maintainability | ||
- Improved layer-based module sharing test coverage | ||
- Removed redundant plugin exports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@module-federation/runtime": minor | ||
--- | ||
|
||
- Added a new property 'layer' of type string or null to SharedConfig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@module-federation/enhanced': minor | ||
--- | ||
|
||
support request option on ConsumeSharePlugin. Allows matching requests like the object key of shared does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@module-federation/enhanced': minor | ||
--- | ||
|
||
Layer support for Provide Share Plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
--- | ||
description: | ||
globs: | ||
alwaysApply: true | ||
--- | ||
|
||
// This file is automatically generated by Nx Console | ||
|
||
You are in an nx workspace using Nx 21.0.3 and pnpm as the package manager. | ||
|
||
You have access to the Nx MCP server and the tools it provides. Use them. Follow these guidelines in order to best help the user: | ||
|
||
# General Guidelines | ||
- When answering questions, use the nx_workspace tool first to gain an understanding of the workspace architecture | ||
- For questions around nx configuration, best practices or if you're unsure, use the nx_docs tool to get relevant, up-to-date docs!! Always use this instead of assuming things about nx configuration | ||
- If the user needs help with an Nx configuration or project graph error, use the 'nx_workspace' tool to get any errors | ||
- To help answer questions about the workspace structure or simply help with demonstrating how tasks depend on each other, use the 'nx_visualize_graph' tool | ||
|
||
# Generation Guidelines | ||
If the user wants to generate something, use the following flow: | ||
|
||
- learn about the nx workspace and any specifics the user needs by using the 'nx_workspace' tool and the 'nx_project_details' tool if applicable | ||
- get the available generators using the 'nx_generators' tool | ||
- decide which generator to use. If no generators seem relevant, check the 'nx_available_plugins' tool to see if the user could install a plugin to help them | ||
- get generator details using the 'nx_generator_schema' tool | ||
- you may use the 'nx_docs' tool to learn more about a specific generator or technology if you're unsure | ||
- decide which options to provide in order to best complete the user's request. Don't make any assumptions and keep the options minimalistic | ||
- open the generator UI using the 'nx_open_generate_ui' tool | ||
- wait for the user to finish the generator | ||
- read the generator log file using the 'nx_read_generator_log' tool | ||
- use the information provided in the log file to answer the user's question or continue with what they were doing | ||
|
||
|
||
# CI Error Guidelines | ||
If the user wants help with fixing an error in their CI pipeline, use the following flow: | ||
- Retrieve the list of current CI Pipeline Executions (CIPEs) using the 'nx_cloud_cipe_details' tool | ||
- If there are any errors, use the 'nx_cloud_fix_cipe_failure' tool to retrieve the logs for a specific task | ||
- Use the task logs to see what's wrong and help the user fix their problem. Use the appropriate tools if necessary | ||
- Make sure that the problem is fixed by running the task that you passed into the 'nx_cloud_fix_cipe_failure' tool | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
description: | ||
globs: packages/enhanced/* | ||
alwaysApply: false | ||
--- | ||
use pnpm enhanced:jest to test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +0,0 @@ | ||
an assistant that engages in extremely thorough, self-questioning reasoning. Your approach mirrors human stream-of- | ||
consciousness thinking, characterized by continuous exploration, self-doubt, and iterative analysis. | ||
## Core Principles | ||
1. EXPLORATION OVER CONCLUSION | ||
- Never rush to conclusions | ||
- Keep exploring until a solution emerges naturally from the evidence | ||
- If uncertain, continue reasoning indefinitely | ||
- Question every assumption and inference | ||
2. DEPTH OF REASONING | ||
- Engage in extensive contemplation (minimum 10,000 characters) | ||
- Express thoughts in natural, conversational internal monologue | ||
- Break down complex thoughts into simple, atomic steps | ||
- Embrace uncertainty and revision of previous thoughts | ||
3. THINKING PROCESS | ||
- Use short, simple sentences that mirror natural thought patterns | ||
- Express uncertainty and internal debate freely | ||
- Show work-in-progress thinking | ||
- Acknowledge and explore dead ends | ||
- Frequently backtrack and revise | ||
- Contemplate before each new action | ||
- Contemplate after each and every step | ||
4. PERSISTENCE | ||
- Value thorough exploration over quick resolution | ||
## Output Format | ||
Your responses | ||
must follow this exact structure given below. | ||
Make sure | ||
to | ||
always include the final answer. | ||
... | ||
<contemplator> | ||
Your extensive internal monologue goes here | ||
- Begin with small, foundational observations | ||
- read each file related to the subject in full, make functional observations | ||
- Question each step thoroughly | ||
- Show natural thought progression | ||
- Express doubts and uncertainties | ||
- Revise and backtrack if you need to | ||
- Continue until natural resolution </contemplator> | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
name: E2E Test for Next.js App Router | ||
|
||
on: | ||
workflow_call: | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
e2e-next-app-router: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 30 | ||
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Install Pnpm | ||
run: | | ||
corepack prepare [email protected] --activate | ||
corepack enable | ||
|
||
- name: Setup Node.js 18 | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: '18' | ||
cache: 'pnpm' | ||
|
||
- name: Set Nx SHA | ||
uses: nrwl/nx-set-shas@v3 | ||
|
||
- name: Set SKIP_DEVTOOLS_POSTINSTALL environment variable | ||
run: echo "SKIP_DEVTOOLS_POSTINSTALL=true" >> $GITHUB_ENV | ||
|
||
- name: Set local webpack | ||
run: echo "NEXT_PRIVATE_LOCAL_WEBPACK=true" >> $GITHUB_ENV | ||
|
||
- name: Install Dependencies | ||
run: pnpm install | ||
|
||
- name: Install Cypress | ||
run: npx cypress install | ||
|
||
- name: Run Build for All | ||
run: npx nx run-many --targets=build --projects=tag:type:pkg | ||
|
||
- name: Run condition check script | ||
id: check-ci | ||
run: node tools/scripts/ci-is-affected.mjs --appName=next-app-router-4000,next-app-router-4001 | ||
|
||
- name: E2E Test for Next.js App Router | ||
if: steps.check-ci.outcome == 'success' | ||
run: npx kill-port --port 4000,4001 || true && pnpm run app:next-router:dev & echo "done" && sleep 25 && npx nx run-many --target=e2e --projects=next-app-router-4000,next-app-router-4001 --parallel=1 && lsof -ti tcp:4000,4001 | xargs kill || true | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,4 +88,6 @@ vitest.config.*.timestamp* | |
.rsbuild | ||
ssg | ||
.claude | ||
__mocks__/ | ||
# Native binary files | ||
*.node | ||
worktrees/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions
Copilot Autofix
AI 6 days ago
To fix the problem, add a
permissions
block at the top level of the workflow file (just after thename:
and beforeon:
), which will apply to all jobs unless overridden. The minimal safe default iscontents: read
, which allows jobs to read repository contents but not write to them. If any job requires additional permissions, those can be set at the job level. In this case, since there is no evidence that any job requires write permissions, settingpermissions: contents: read
at the workflow level is the best fix. This change should be made at the top of.github/workflows/build-and-test.yml
, after thename:
line and before theon:
block.