-
-
Notifications
You must be signed in to change notification settings - Fork 357
feat(nextjs-mf): RSC Support #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr9-implementation
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f9ec75f The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for module-federation-docs failed. Why did it fail? →
|
25626cf
to
2ee38ff
Compare
94b858a
to
4bd1354
Compare
needs: checkout-install | ||
uses: ./.github/workflows/e2e-next-app-router.yml | ||
secrets: inherit |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 days ago
To fix the problem, add a permissions
block at the top level of the workflow file (just after the name:
and before on:
), which will apply to all jobs unless overridden. The minimal safe default is contents: read
, which allows jobs to read repository contents but not write to them. If any job requires additional permissions, those can be set at the job level. In this case, since there is no evidence that any job requires write permissions, setting permissions: contents: read
at the workflow level is the best fix. This change should be made at the top of .github/workflows/build-and-test.yml
, after the name:
line and before the on:
block.
-
Copy modified lines R2-R3
@@ -1,2 +1,4 @@ | ||
name: Build Affected Packages | ||
permissions: | ||
contents: read | ||
|
806abf2
to
217ba68
Compare
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1fbe79b
to
93507be
Compare
e90cbb9
to
d47ebc1
Compare
93507be
to
3d6dd83
Compare
d47ebc1
to
eac5e94
Compare
3d6dd83
to
60d6549
Compare
…App Router applications - Update Next.js environment type definitions for improved compatibility - Enhance context click counter component with better error boundaries - Add comprehensive error handling pages for nested route structures - Improve hooks demonstration page with additional Next.js navigation APIs - Update main layout and page components with better remote component integration - Add Cypress e2e test configurations for module federation validation - All changes support enhanced nodeModulesReconstructedLookup functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…4001 remote application - Update Next.js environment type definitions with navigation compatibility - Enhance router context layout with improved hooks implementation - Update ISR layout with better tab group integration - Improve main layout with enhanced global navigation and error boundaries - Update category layout with async parameter handling for React 19 - Enhance main page with Random component integration - Update Next.js configuration with enhanced module federation settings - Upgrade package dependencies to React 19 with proper type definitions - Remove demo page that was added inadvertently - All changes support enhanced nodeModulesReconstructedLookup functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… node packages - Enhance Node.js runtime plugin with improved filesystem loading capabilities - Add comprehensive semver testing for complex version range scenarios including OR ranges - Update runtime core constants for better default remote type handling - Improve core federation host with enhanced plugin deduplication logic - Enhance remote module loading with better module resolution and matching - Remove unnecessary mock fsevents binary file from test suite - All changes support enhanced nodeModulesReconstructedLookup functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ignore - Update Next.js 4000 app configuration with enhanced module federation settings - Upgrade Next.js 4000 package dependencies to React 19 with proper script handling - Enhance address bar component with improved remote button integration - Update global navigation component with better layout and navigation handling - Add .node binary files to .gitignore to prevent accidental commits - Complete incremental merge of all enhanced nodeModulesReconstructedLookup features 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…mporary files - Restore __mocks__/remotes/index.js for proper test mocking - Restore missing pages/router-test.tsx files for both Next.js applications - Restore missing button components (classic/button.tsx, rsc/button.tsx) - Restore ui/random.tsx component - Remove temporary pnpm-lock.yaml files and development artifacts - Complete final synchronization between branches 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove __mocks__/remotes/index.js that was inadvertently restored - Update pnpm-lock.yaml with latest dependency resolutions - Final cleanup to ensure branches are properly synchronized 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixed failing e2e-next tests by reverting nextjs-mf dependencies from fixed version '0.0.0-next-20250701105507' back to 'workspace:*' in: - apps/3001-shop/package.json - apps/3002-checkout/package.json This resolves module loading issues where the apps couldn't find the nextjs-mf patches directory, allowing proper Next.js federation to work correctly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixed NextFederationPlugin to use correct path '../../loaders/next-flight-loader' instead of '../../patches/next-flight-loader' since the patches directory doesn't exist. This resolves module loading errors for Next.js 15+ apps. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… commit Restored missing e2e target configurations from the last working commit 9b7dff2: - Added defaultConfiguration: "development" for both apps - Added development configuration with devServerTarget - Fixed production configuration for 3002-checkout to use devServerTarget This matches the old CI infrastructure that was working properly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Reverted to the main branch pattern where each e2e test manages its own server dependencies: - Updated GitHub workflows to run individual test:e2e commands - Restored project.json test:e2e configurations from main branch - Each app now starts required federated dependencies before testing - Removed centralized server management approach Shop e2e tests are now working properly with automatic dependency management. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Co-authored-by: Hanric <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Wei Tang Lin <[email protected]> Co-authored-by: Claude <[email protected]>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude <[email protected]>
Created a detailed plan to split the massive changes in packages/enhanced into 12 focused, incremental PRs: - Runtime safety fixes (independent) - Hook renaming refactor - Container hoisting improvements - Share filtering features (broken into 4 sub-features) - Layer support enhancements - API exports and test coverage Each PR is self-contained with clear dependencies documented. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Created a detailed plan to split the massive changes in packages/enhanced into 12 focused, incremental PRs: - Runtime safety fixes (COMPLETED - PR #3900) - Hook renaming refactor - Container hoisting improvements - Share filtering features (broken into 4 sub-features) - Layer support enhancements - API exports and test coverage Each PR is self-contained with clear dependencies documented. Also added worktrees/ to .gitignore 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Co-authored-by: Zack Jackson <[email protected]>
Add missing module declarations for shop remote in remotes.d.ts to fix TypeScript compilation errors that were causing the Next.js application to fail with 500 Internal Server Error during Cypress E2E tests. The missing declarations included: - shop/menu - shop/pages/shop/index - shop/pages/shop/exposed-pages - shop/pages/shop/test-webpack-png - shop/pages/shop/test-webpack-svg - shop/pages/shop/products/[...slug] 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Updated test expectations to match the new error message format when loadShareSync is called incorrectly from the runtime. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Apply suggested changes
c476e89
to
58442a7
Compare
60d6549
to
055deac
Compare
This pull request includes various changes across documentation, configuration, and code enhancements for the Module Federation plugin. The key updates include the addition of new experimental features, enhancements to shared module configurations, and improvements to testing and dependency management.
Documentation Updates:
nodeModulesReconstructedLookup
experiment inapps/website-new/docs/en/configure/experiments.mdx
, explaining its purpose and usage for resolving relative imports innode_modules
.packageName
,shareKey
,strictVersion
, andversion
) for shared configurations inapps/website-new/docs/en/configure/shared.mdx
. These properties enhance control over shared module behavior.Experimental Features:
nodeModulesReconstructedLookup
experiment inapps/website-new/docs/en/configure/experiments.mdx
andpackages/enhanced/src/lib/container/ModuleFederationPlugin.ts
to improve module resolution for shared dependencies. [1] [2]Code Enhancements:
exclude
andinclude
options in theProvideSharedPlugin
to allow filtering shared modules by version or request. [1] [2]ProvideSharedPlugin
to encapsulate the logic for providing shared modules, improving maintainability. [1] [2]Testing Improvements:
test/compiler-unit/**/*.test.ts
inpackages/enhanced/jest.config.ts
andpackage.json
. This ensures the new features and configurations are thoroughly tested. [1] [2]Dependency Management:
@module-federation/cli
as a dependency inpackages/enhanced/package.json
to support CLI operations for the enhanced package. [1] [2]Related Issue
Types of changes
Checklist