refactor(manifest): improve asset tracking and manifest generation #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gioboa have you been able to look at this at all? |
Thanks for the ping. I look at it now. |
gioboa
reviewed
Aug 22, 2025
gioboa
reviewed
Aug 22, 2025
updated. |
pcfreak30
changed the title
pcfreak30
force-pushed
the
css-support
branch
2 times, most recently
from
7465b6d to
399d662
Compare
pcfreak30
changed the title
|
@gioboa i did a rather large refactor and moved the primary logic to |
gioboa
approved these changes
Aug 23, 2025
- Extracted asset tracking logic into dedicated cssModuleHelpers utility - Added comprehensive tests for new helper functions - Improved manifest generation with better CSS asset handling - Added type safety and documentation throughout - Optimized module processing with early exit conditions
|
@gioboa branch updated |
gioboa
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st in a series of PR's im submitting thats the result of me needing to evolve the plugin to support new things.
I will also make a note here that you do NOT need to have css support likely in dev mode b/c vite seems to inline all css when reading from the js files, especially under HMR.
This commit has been in use for months by me, and im open to changes to it. It mainly exposes all css files to be put in all expose entries.
Original PR at #257
Closes #253