Conversation
✅ Deploy Preview for monarch-app canceled.
|
…h to using the pydantic classes in the api, also update linkml and switch to the standard way of including dev packages so that they get installed with plain uv sync
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 72.07% 71.73% -0.34%
==========================================
Files 92 95 +3
Lines 3255 3404 +149
==========================================
+ Hits 2346 2442 +96
- Misses 909 962 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive API endpoints for Information Resources (infores) registry, implementing LinkML schema support with proper Pydantic models. The changes enable CRUD operations on information resources through RESTful endpoints with both JSON and TSV output formats.
Key Changes:
- Added InformationResource class to LinkML schema with required fields (id, status, knowledge_level, agent_type)
- Implemented infores API endpoints with full CRUD functionality and format support
- Updated Solr implementation to use direct dictionary unpacking for type safety
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/src/monarch_py/datamodels/model.yaml | Added InformationResource class definition with infores-specific slots |
| backend/src/monarch_py/api/infores.py | New API router with catalog and individual infores endpoints |
| backend/src/monarch_py/implementations/solr/solr_implementation.py | Added get_infores and get_infores_catalog methods |
| frontend/src/api/model.ts | Added TypeScript interface for InformationResource |
| backend/tests/api/test_infores_router.py | Comprehensive API tests for infores endpoints |
| backend/tests/integration/test_solr_infores.py | Integration tests for Solr infores functionality |
Comments suppressed due to low confidence (1)
backend/src/monarch_py/api/infores.py:50
- The function name '_get_entity' is misleading as it actually retrieves an information resource, not an entity. It should be renamed to '_get_infores' to accurately reflect its purpose.
async def _get_entity(
backend/src/monarch_py/implementations/solr/solr_implementation.py
Outdated
Show resolved
Hide resolved
backend/src/monarch_py/implementations/solr/solr_implementation.py
Outdated
Show resolved
Hide resolved
…n.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fixes #1051
🎯 Core Changes: Added proper LinkML schema support for Information Resources
📋 Schema Changes (model.yaml & model.py)
agent_type)
🔧 Implementation Changes
🧪 Test Updates
⚙️ Build/Config Changes
✅ Benefits Achieved
Files Modified: 6 core files + comprehensive test updates, ~200 lines of meaningful changes after model regeneration.