Fix Docker image tagging confusion with conditional logic#1184
Open
kevinschaper wants to merge 1 commit intomainfrom
Open
Fix Docker image tagging confusion with conditional logic#1184kevinschaper wants to merge 1 commit intomainfrom
kevinschaper wants to merge 1 commit intomainfrom
Conversation
…n event type - Use github.event_name to distinguish between releases and main branch pushes - For releases: tag with 'latest' and actual release version - For main branch: tag with 'latest-dev' and branch-specific tags (no 'latest') - Eliminates the issue where main branch pushes were incorrectly tagged with old release versions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 92 92
Lines 3255 3255
=======================================
Hits 2346 2346
Misses 909 909 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where main branch pushes were incorrectly tagged with old release versions, causing confusion about when releases were actually happening.
Changes
Simple conditional fix using
github.event_name:github.event_name == "release"): Tag withlatestand actual release versionlatest-devand branch-specific tags (nolatesttag)Benefits
latesttag only used for actual releases,latest-devfor developmentBefore/After
Before: Main branch push → Image tagged with
latest,v1.2.3(old release), and SHAAfter: Main branch push → Image tagged with
latest-dev,main-<sha>, and SHABefore: Release published → Image tagged with
latest,v1.2.3(old release), and SHAAfter: Release published → Image tagged with
latest,v1.4.0(actual release), and SHAThis approach solves the core problem with the absolute minimum change required.
🤖 Generated with Claude Code