Skip to content

Patient & Clinical Resources: UI Clean-Up#1225

Open
varun-divya wants to merge 1 commit intomainfrom
issue-1224-resources-ui-clean-up
Open

Patient & Clinical Resources: UI Clean-Up#1225
varun-divya wants to merge 1 commit intomainfrom
issue-1224-resources-ui-clean-up

Conversation

@varun-divya
Copy link
Contributor

Related issues

Summary

  • adds ...
  • changes ...
  • fixes ...
  • removes ...

Checks

  • All tests have passed (or issues created for failing tests)

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 6b4e637
🔍 Latest deploy log https://app.netlify.com/projects/monarch-app/deploys/6909222725a6e40008f0749a
😎 Deploy Preview https://deploy-preview-1225--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.84%. Comparing base (1f2828a) to head (6b4e637).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1225   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          92       92           
  Lines        3232     3232           
=======================================
  Hits         2322     2322           
  Misses        910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@varun-divya varun-divya self-assigned this Nov 3, 2025
Copy link
Member

@sagehrke sagehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ticket may be unnecessary.

I think this issue is actually the medgen g2d data issue that is being worked on (#1226) because diseases shouldn't show more than 1 casual gene. so I think this change is unnecessary. Once the data is fixed, it will fix any weird formatting issues. @kevinschaper can you confirm this please? The max causal genes that should display at the top would be 2 but pretty much all will have 1 if they have a causal gene.

That being said, If Kevin confirms this is true, we can make the formatting change, I just don't think it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patient & Clinical Resources: UI Clean-Up

2 participants

Comments