fix: update push-to-gcr-github-action to v5

[kevinschaper]

Summary

• Updates RafikFarhad/push-to-gcr-github-action from v5-rc1/v5-beta to v5 in both Docker build workflows
• GitHub runners upgraded their Docker engine to require API version 1.44+, but the old action versions bundle Docker client API 1.41, causing all image builds to fail
• The v5 release includes Docker CLI 29.2.1 which resolves the compatibility issue

Test plan

• Verify the Docker image build action passes on this branch (triggered on push to main or via workflow_dispatch)

🤖 Generated with Claude Code

[netlify]

✅ Deploy Preview for monarch-app ready!

Name	Link
🔨 Latest commit	321a8ed
🔍 Latest deploy log	https://app.netlify.com/projects/monarch-app/deploys/698f780bfec45a000836a192
😎 Deploy Preview	https://deploy-preview-1257--monarch-app.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[claude]

PR Review: Update push-to-gcr-github-action to v5

Summary

This PR updates the RafikFarhad/push-to-gcr-github-action from pre-release versions (v5-rc1 and v5-beta) to the stable v5 release to resolve Docker API compatibility issues with GitHub-hosted runners.

---

✅ Strengths

1. Critical Bug Fix: Addresses a breaking change where GitHub runners' Docker engine now requires API version 1.44+, which was incompatible with the old action versions bundling Docker client API 1.41.

2. Consistent Updates: All four instances of the action across both workflow files are updated uniformly, ensuring consistency.

3. Clear Documentation: The PR description clearly explains the problem, the root cause, and the solution.

4. Minimal, Focused Change: The PR is appropriately scoped - only updating the action versions without introducing unrelated changes.

---

📝 Observations & Suggestions

Code Quality

• Good: The changes are minimal and surgical - only updating version tags
• Good: Both workflows are updated consistently from their respective pre-release versions (v5-rc1 and v5-beta) to v5

Testing Considerations

• The test plan mentions verifying the Docker image build action passes, but this should be confirmed before merging
• Suggestion: Consider running the build-images-for-branch.yaml workflow manually via workflow_dispatch to verify the fix works as expected before merging

Action Pinning Best Practice

• Currently using tag-based pinning (@v5), which is mutable
• Consideration: For production workflows, consider pinning to a specific commit SHA for better security and reproducibility:

  uses: RafikFarhad/push-to-gcr-github-action@<commit-sha> # v5

  This prevents potential supply chain attacks where the v5 tag could be moved to point to different code

Workflow Configuration Note

• I noticed .github/workflows/build-images-for-branch.yaml:4-5 is currently configured to trigger on the issue-982-about-dropdown branch
• This appears to be a development/testing configuration that may need updating in a future PR

---

🔒 Security

• No security concerns introduced by this change
• The action continues to use the same secrets (JSON_GCLOUD_SERVICE_ACCOUNT_JSON)
• Upgrading from pre-release to stable release reduces risk

---

🚀 Performance

• No performance impact expected
• The newer Docker CLI version should maintain or improve build performance

---

✅ Recommendation

APPROVE - This is a necessary infrastructure fix that resolves a breaking compatibility issue. The changes are minimal, well-explained, and consistently applied.

Before merging: Verify that the workflow runs successfully with the updated action version (as noted in the test plan checklist).

---

Minor Follow-up Items (for future PRs, not blocking):

1. Consider pinning GitHub Actions to commit SHAs for enhanced security
2. Review whether build-images-for-branch.yaml should still target the issue-982-about-dropdown branch

---

Review conducted by Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.51%. Comparing base (042a914) to head (321a8ed).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files          95       95           
  Lines        3417     3417           
=======================================
  Hits         2512     2512           
  Misses        905      905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.