adding semsim distribution plot analysis#188
Open
souzadevinicius wants to merge 5 commits intomainfrom
Open
Conversation
Member
yaseminbridges
left a comment
yaseminbridges
left a comment
There was a problem hiding this comment.
Looks good! I just had a few minor comments
| semsim_score_distribution_plot(input, score_column, output) | ||
|
|
||
|
|
||
| def filter_non_0_score(data: pl.DataFrame, col: str) -> pd.DataFrame: |
Member
There was a problem hiding this comment.
Have you got tests for all these other semsim util functions?
Member
Author
There was a problem hiding this comment.
They are implement on test_cli.py file.
But have to be improved
Member
There was a problem hiding this comment.
I can see that there is a test for the CLI command in test_cli.py, what I meant is do you have tests for all the smaller methods that you are calling? Like the diff_semsim method in semsim_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187 and #180
Including semsim score distribution plots and improving the performance of data handling through the pandas to polars library replacement