Removing H2 jar as internal dependency. Fixes #291#292
Removing H2 jar as internal dependency. Fixes #291#292souzadevinicius wants to merge 1 commit intomainfrom
Conversation
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Looks like a good move to me, but better have a @yaseminbridges review for details
|
Hardcoding the H2 file is going to break on the new version as the database file format is not stable. The best place to get the dependency from would be the exomiser-cli-/lib folder as this is the version used to create and read the files. |
julesjacobsen
left a comment
julesjacobsen
left a comment
There was a problem hiding this comment.
See my comment - in the PR
|
@souzadevinicius Sorry, I've completely forgotten about this! I wonder if things have changed a bit more since this was first looked and and we need to revisit what the point of the methods using this file is. The intention of these are to be able to load arbitrary semsim data into an Exomiser database to be able to run it in a pheval benchmark. This is fine, but it doesn't belong in this pheval repo and needs to be removed somewhere else. There should be no application-specific code in this repo as this is essentially a library which other runners/projects need to import and none of them will need this code. Can you please move it into another repo. |
4 participants
Fixes #291