Skip to content

fix: add missing @vibe/style dependency to component packages #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rivka-ungar merged 1 commit into from
Mar 12, 2026
Merged

fix: add missing @vibe/style dependency to component packages #3330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@vibe/icon": "^4.0.0-alpha.1",
"@vibe/loader": "^4.0.0-alpha.1",
"@vibe/shared": "^4.0.0-alpha.1",
"@vibe/style": "^4.0.0-alpha.1",
Copy link
Copy Markdown
Contributor

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Base missing style dependency 🐞 Bug ⛯ Reliability

@vibe/base imports "~@vibe/style/dist/mixins" in its SCSS but still does not declare @vibe/style in
dependencies, so building @vibe/base can fail to resolve that import. The PR only fixes some
component packages, leaving the monorepo with the same missing-dependency class of failure in
@vibe/base.
Agent Prompt 
## Issue description
`@vibe/base` imports SCSS from `~@vibe/style/dist/...` but does not declare `@vibe/style` in `dependencies`, so builds that compile `@vibe/base` styles can fail to resolve the import.

## Issue Context
This PR adds `@vibe/style` to several component packages to fix SCSS import resolution/build ordering. The same pattern exists in `@vibe/base`.

## Fix Focus Areas
- packages/base/package.json[40-43]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

"classnames": "^2.5.1",
"es-toolkit": "^1.39.10"
},
Expand Down
1 change: 1 addition & 0 deletions packages/components/clickable/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
},
"dependencies": {
"@vibe/shared": "^4.0.0-alpha.1",
"@vibe/style": "^4.0.0-alpha.1",
"classnames": "^2.5.1",
"es-toolkit": "^1.39.10"
},
Expand Down
1 change: 1 addition & 0 deletions packages/components/dialog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"@vibe/hooks": "^4.0.0-alpha.1",
"@vibe/layer": "^4.0.0-alpha.1",
"@vibe/shared": "^4.0.0-alpha.1",
"@vibe/style": "^4.0.0-alpha.1",
"classnames": "^2.5.1",
"es-toolkit": "^1.39.10",
"react-transition-group": "^4.4.5"
Expand Down
1 change: 1 addition & 0 deletions packages/components/layout/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"dependencies": {
"@vibe/clickable": "^4.0.0-alpha.1",
"@vibe/shared": "^4.0.0-alpha.1",
"@vibe/style": "^4.0.0-alpha.1",
"classnames": "^2.5.1",
"es-toolkit": "^1.39.10"
},
Expand Down
1 change: 1 addition & 0 deletions packages/components/tooltip/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"@vibe/icon": "^4.0.0-alpha.1",
"@vibe/layout": "^4.0.0-alpha.1",
"@vibe/shared": "^4.0.0-alpha.1",
"@vibe/style": "^4.0.0-alpha.1",
"classnames": "^2.5.1",
"es-toolkit": "^1.39.10"
},
Expand Down
Loading