fix: add missing @vibe/style dependency to component packages#3330
Merged
rivka-ungar merged 1 commit intovibe4from Mar 12, 2026
Merged
fix: add missing @vibe/style dependency to component packages#3330rivka-ungar merged 1 commit intovibe4from
rivka-ungar merged 1 commit intovibe4from
Conversation
SCSS files in these packages import from @vibe/style/dist/mixins but didn't declare it as a dependency, causing build failures on clean builds when @vibe/style hasn't been built yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Review Summary by QodoAdd missing @vibe/style dependency to component packages
WalkthroughsDescription• Added @vibe/style dependency to 5 component packages • Fixes build failures on clean builds when SCSS imports resolve to local workspace • Ensures correct build ordering for packages importing from @vibe/style/dist/mixins/ Diagramflowchart LR
A["Component Packages<br/>button, clickable, dialog,<br/>layout, tooltip"] -- "import from" --> B["@vibe/style/dist/mixins/"]
B -- "requires dependency" --> C["@vibe/style package"]
C -- "must build first" --> D["Clean build success"]
File Changes1. packages/components/button/package.json
|
Contributor
Code Review by Qodo
1. Base missing style dependency
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
| "@vibe/icon": "^4.0.0-alpha.1", | ||
| "@vibe/loader": "^4.0.0-alpha.1", | ||
| "@vibe/shared": "^4.0.0-alpha.1", | ||
| "@vibe/style": "^4.0.0-alpha.1", |
Contributor
There was a problem hiding this comment.
1. Base missing style dependency 🐞 Bug ⛯ Reliability
@vibe/base imports "~@vibe/style/dist/mixins" in its SCSS but still does not declare @vibe/style in dependencies, so building @vibe/base can fail to resolve that import. The PR only fixes some component packages, leaving the monorepo with the same missing-dependency class of failure in @vibe/base.
Agent Prompt
## Issue description
`@vibe/base` imports SCSS from `~@vibe/style/dist/...` but does not declare `@vibe/style` in `dependencies`, so builds that compile `@vibe/base` styles can fail to resolve the import.
## Issue Context
This PR adds `@vibe/style` to several component packages to fix SCSS import resolution/build ordering. The same pattern exists in `@vibe/base`.
## Fix Focus Areas
- packages/base/package.json[40-43]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
talkor
approved these changes
Mar 12, 2026
Contributor
|
📦 Bundle Size Analysis Changed Components
Unchanged Components
📊 Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vibe/styleas a dependency to 5 component packages (clickable,button,dialog,layout,tooltip) that import from@vibe/style/dist/mixins/in their SCSS files but didn't declare itdist/) where@vibe/stylehadn't been built yet when these packages tried to compile their SCSSmonday-ui-style(an npm-published package with pre-builtdist/), but after renaming to@vibe/stylethey now resolve to the local workspace package which requires correct build orderingTest plan
yarn buildfrom a clean state (after deleting alldist/folders) and verify no SCSS import errors🤖 Generated with Claude Code