chore: force package-lock to update the mismatched dependencies #6348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last mongosh version bump we actually haven't bumped the dependencies to the latest, they got updated in package.json files, but not in the package-lock.json, so correct versions were never installed:
The weirdest part is that even manually trying to install exact version was completely ignored by npm, I'll try to dig a bit more into that because it's a scary thing and very hard to spot when doing package version update, but for not to unblock the release I took the following steps:
@mongosh/*and@mongodb-js/devtools-*packages from package-lock.json (but not from package.json)Taking this steps managed to make lockfile to update correctly. Also worth calling out that there are still some mismatched deps left that are not related to the mongosh version bump (and are not getting bunled in prod, so less scary), so I'm keeping them out of this PR, but will follow up with a fix for those too, but as a separate patch.