chore: fix more mismatched versions issues and add a check in ci #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
commented
Oct 11, 2024
| # Will fail if versions of direct dependencies listed in package-lock | ||
| # are not matching versions defined in package.json file of any of the | ||
| # workspace packages | ||
| # TODO: change this to npm ls --all when rest of the mismatched version issues are resolved |
Collaborator
Author
There was a problem hiding this comment.
No ticket because I'll just do it right away (or will add a ticket if resolving the issue for transitive deps will turn out to take longer than expected)
lerouxb
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6348 that fixes two more dependencies (make-fetch-happen and semver) in some workspaces (scripts, compass, and compass-e2e-tests) and adds a check that should make sure that at least we will be able to spot immediately when we run into issues like that in the future