feat: check the contents of zip or tar.gz packages against allow lists COMPASS-8743 #6679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
changed the title
lerouxb
force-pushed
the
package-allow-lists
branch
2 times, most recently
from
c4801f8 to
1360e6a
Compare
lerouxb
force-pushed
the
package-allow-lists
branch
from
1360e6a to
4bdb8c9
Compare
lerouxb
force-pushed
the
package-allow-lists
branch
from
49c5f2a to
e385a2e
Compare
lerouxb
force-pushed
the
package-allow-lists
branch
from
6e34ecb to
1744adf
Compare
lerouxb
force-pushed
the
package-allow-lists
branch
from
df7164f to
cdbccfe
Compare
gribnoysup
approved these changes
Feb 18, 2025
| "APP-SUFFIX/resources/app.asar", | ||
| "APP-SUFFIX/resources/app.asar.fully-unpacked", | ||
| "APP-SUFFIX/resources/app.asar.fully-unpacked/build", | ||
| "APP-SUFFIX/resources/app.asar.fully-unpacked/build/**/*", |
Collaborator
There was a problem hiding this comment.
Don't have a strong preference, not sure if it's needed, but maybe we want to limit it to some known extensions to make sure nothing that we don't expect to bundle got in the build dir by webpack accidentally copying it over
Contributor
Author
There was a problem hiding this comment.
Makes sense. I tightened up the patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each platform, check a .zip or .tar.gz package's contents against a minimatch pattern list.