chore(schema-validation): add progress toast COMPASS-8861 #6767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oops meant to open as a draft and hit enter, closing and will re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of COMPASS-8861
Opening as a draft as I want to clear up if we want all 3 of these toasts, some of them, or none at all. For errors it can be loud, while we also show the error in the UI:
The success toast is a bit outside of the user's flow, as the
updateCollectioncommand that's run is almost always instant. I did find it to be a nice affirmation though.There isn't currently any way that visually indicates that the validation rule update is in progress, so I do think that toast could be nice. That being said we should also disable the update button until the response is in. I started refactoring