Skip to content

chore(validation): add success toast on validation update COMPASS-8861 #6770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

chore(validation): add success toast on validation update COMPASS-8861 #6770

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bf2a96
COMPASS-8861-add-success-toast
Anemy Mar 4, 2025
4745f51
fixup: e2e test close toast
Anemy Mar 5, 2025
5e7e375
update packages/compass-schema-validation/src/modules/validation.ts
Anemy Mar 5, 2025
27708e1
merge main
Anemy Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/compass-e2e-tests/helpers/commands/set-validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ export async function setValidation(

await browser.clickVisible(Selectors.UpdateValidationButton);

// Close toast.
await browser.clickVisible(
Selectors.closeToastButton(Selectors.ValidationSuccessToast)
);

// both buttons should become hidden if it succeeds
await validationActionMessageElement.waitForDisplayed({
reverse: true,
Expand Down
2 changes: 2 additions & 0 deletions packages/compass-e2e-tests/helpers/selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,8 @@ export const ValidationActionMessage =
'[data-testid="validation-action-message"]';
export const UpdateValidationButton =
'[data-testid="update-validation-button"]';
export const ValidationSuccessToast =
'[data-testid="toast-schema-validation-update"]';
export const ValidationMatchingDocumentsPreview =
'[data-testid="validation-content"] [data-testid="matching-documents"] [data-testid="document-preview"]';
export const ValidationLoadMatchingDocumentsBtn = `${ValidationMatchingDocumentsPreview} [data-testid="load-sample-document"]`;
Expand Down
9 changes: 8 additions & 1 deletion packages/compass-schema-validation/src/modules/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { RootAction, RootState, SchemaValidationThunkAction } from '.';
import { EJSON } from 'bson';
import { EJSON, ObjectId } from 'bson';
import { parseFilter } from 'mongodb-query-parser';
import { stringify as javascriptStringify } from 'javascript-stringify';
import { openToast } from '@mongodb-js/compass-components';
import { clearSampleDocuments } from './sample-documents';
import { zeroStateChanged } from './zero-state';
import { isLoadedChanged } from './is-loaded';
Expand Down Expand Up @@ -450,6 +451,8 @@ export function validationFromCollection(
};
}

const toastId = 'schema-validation-update';

/**
* Save validation.
*/
Expand Down Expand Up @@ -486,6 +489,10 @@ export const saveValidation = (
}
);
dispatch(fetchValidation(namespace));
openToast(toastId, {
title: 'New validation rules applied',
variant: 'success',
});
} catch (error) {
dispatch(validationSaveFailed(error as Error));
}
Expand Down