chore(release): unblock workflows for update electron COMPASS-9075 #6779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 6, 2025
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Looks good but we really should prioritize the actual bump, and for this PR, and maybe we'd want to leave a TODO comment with a ticket for re-enabling the node-abi package in this script?
gribnoysup
approved these changes
Mar 6, 2025
Collaborator
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
Probalby can be a bit more detailed with a comment there, but not a blocker otherwise
Co-authored-by: Sergey Petushkov <[email protected]>
…ompass into COMPASS-9075-electron-bumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes