chore: use switch-exhaustiveness-check, add updatemany to fixtures #6819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Mar 26, 2025
| { | ||
| files: ['**/*.ts'], | ||
| rules: { | ||
| '@typescript-eslint/switch-exhaustiveness-check': 'error', |
Contributor
Author
There was a problem hiding this comment.
We could also enable this everywhere, but I imagine that could cause unintended failures we have to fix and I'd rather do that separately.
Collaborator
There was a problem hiding this comment.
Can you file a ticket to do this if we're not trying to do this right away?
Contributor
Author
There was a problem hiding this comment.
lerouxb
changed the title
lerouxb
force-pushed
the
exhaustive-checks
branch
from
b6c5915 to
cfacd80
Compare
lerouxb
added
the
no-title-validation
gribnoysup
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #6817