Skip to content

chore(indexes): update padding to allow for focus ring to show on toolbar buttons #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

chore(indexes): update padding to allow for focus ring to show on toolbar buttons #6920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf9af2
chore(indexes): update padding to allow for full focus ring to show o…
Anemy May 13, 2025
ec623c0
Merge branch 'main' into fix-indexes-button-wrapper
Anemy May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/compass-indexes/src/components/indexes-toolbar/indexes-toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ const toolbarButtonsContainer = css({
alignItems: 'center',
});

const indexesToolbarContainerStyles = css({
padding: spacing[400],
paddingBottom: 0,
});

const alignSelfEndStyles = css({
marginLeft: 'auto',
});
Expand Down Expand Up @@ -98,7 +103,10 @@ export const IndexesToolbar: React.FunctionComponent<IndexesToolbarProps> = ({
);

return (
<div data-testid="indexes-toolbar-container">
<div
className={indexesToolbarContainerStyles}
data-testid="indexes-toolbar-container"
>
{!isReadonlyView && (
<div data-testid="indexes-toolbar">
<div className={toolbarButtonsContainer}>
Expand Down
9 changes: 3 additions & 6 deletions packages/compass-indexes/src/components/indexes/indexes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ import CreateIndexModal from '../create-index-modal/create-index-modal';
const IDEAL_NUMBER_OF_MAX_INDEXES = 10;

const containerStyles = css({
paddingTop: spacing[400],
paddingLeft: spacing[400],
paddingRight: spacing[400],
// No padding bottom so that the table can scroll visibly to the bottom
paddingBottom: 0,
gap: spacing[400],
display: 'flex',
flexDirection: 'column',
Expand Down Expand Up @@ -106,7 +101,9 @@ function isRefreshingStatus(status: FetchStatus) {
}

const indexesContainersStyles = css({
paddingTop: spacing[400],
padding: spacing[400],
// No padding bottom so that the table can scroll visibly to the bottom.
paddingBottom: 0,
display: 'grid',
gridTemplateColumns: '100%',
gap: spacing[200],
Expand Down