chore(smoke-tests): use fs.existsSync instead of running compass to verify installs COMPASS-9406#6963
Merged
gribnoysup merged 1 commit intomainfrom May 26, 2025
Conversation
Contributor
Author
|
I've restarted the task 5 times and it's passed every time 🎉 |
lerouxb
approved these changes
May 25, 2025
Member
|
yay! We could also do this the same for the other platforms. |
Collaborator
|
@kraenhansen hope you don't mind, I'll merge it to see if the cloud bot will be satisfied by this fix 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to make the smoke / install tests less brittle by asserting the existence of the Compass executable instead of actually running it.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes