chore(eslint-config): replace no-unused-expressions with chai-friendly version COMPASS-9459 #7018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
the
no-title-validation
Anemy
approved these changes
Jun 13, 2025
gribnoysup
changed the title
gribnoysup
removed
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just enabling the rule causes a ton of failures for chai expect usage. Not sure why this wasn't failing for us before to be very honest, but this eslint plugin was made specifically so that no unused expression can be still used without issues while still keeping the check for other cases (some legit failures you can see in the fixes I did)