chore(eslint): re-enable no-unused-vars for catch blocks; re-enable no-redundant-type-constituents and clean up redundant COMPASS-9459 #7023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le no-redundant-type-constituents and clean up redundant
gribnoysup
changed the title
…ed-vars-no-redundant-type-constituents
Anemy
approved these changes
Jun 16, 2025
gribnoysup
deleted the
eslint-enable-no-unused-vars-no-redundant-type-constituents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was the most annoying one (so far) and I messed it up a bit by accidentally doing two rules in one go. The bulk of the changes here just cleans up unused errors in catch blocks, another one is removing redundant type definitions (things like
unknown | stringwhereunknownjust overridese everything), to make this straightforward I'm just cleaning those up instead of trying to address any of them