chore(smoke-tests): windows fixes #7038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
no release notes
lerouxb
reviewed
Jun 18, 2025
| [ | ||
| // Args are passed through to the Update.exe https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Setup/winmain.cpp#L125 | ||
| // See options in https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Update/StartupOption.cs | ||
| '--silent', |
Contributor
There was a problem hiding this comment.
What does --silent do, though? That link just says { "s|silent", "Silent install", _ => silentInstall = true},
Contributor
Author
There was a problem hiding this comment.
It'll avoid showing the install GUI and starting the application (which is what I think might be causing some issues).
lerouxb
approved these changes
Jun 18, 2025
gribnoysup
approved these changes
Jun 18, 2025
Contributor
Author
|
This had three successful executions in a row 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will:
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes