Skip to content

chore(smoke-tests): windows fixes #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025
Merged

chore(smoke-tests): windows fixes #7038

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4e2ea3
Only remove windows installer if it exists
kraenhansen Jun 18, 2025
a777a2f
Warn if removal fails
kraenhansen Jun 18, 2025
e2b738b
Passing SQUIRREL_TEMP to sandbox the install
kraenhansen Jun 18, 2025
ba6284d
Use --checkInstall to silence the Update.exe
kraenhansen Jun 18, 2025
1eb64a9
Add a debug statement with the executable
kraenhansen Jun 18, 2025
8342980
Pass --silent directly
kraenhansen Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions packages/compass-smoke-tests/src/installers/windows-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export function installWindowsSetup({
kind,
filepath,
buildInfo,
sandboxPath,
}: InstallablePackage): InstalledAppInfo {
assert.equal(kind, 'windows_setup');
const appName = buildInfo.installerOptions.name;
Expand Down Expand Up @@ -62,7 +63,18 @@ export function installWindowsSetup({
debug(`Running command to uninstall: ${uninstallCommand}`);
cp.execSync(uninstallCommand, { stdio: 'inherit' });
// Removing the any remaining files manually
fs.rmSync(installLocation, { recursive: true, force: true });
try {
if (fs.existsSync(installLocation)) {
debug(`Removing installer: ${installLocation}`);
fs.rmSync(installLocation, { recursive: true, force: true });
}
} catch (error) {
console.warn(
`Failed to remove install location ${installLocation}: ${
error instanceof Error ? error.message : error
}`
);
}
}
}

Expand All @@ -72,7 +84,20 @@ export function installWindowsSetup({
console.warn(
"Installing globally, since we haven't discovered a way to specify an install path"
);
execute(filepath, []);
execute(
filepath,
[
// Args are passed through to the Update.exe https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Setup/winmain.cpp#L125
// See options in https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Update/StartupOption.cs
'--silent',
Copy link
Contributor

@lerouxb lerouxb Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does --silent do, though? That link just says { "s|silent", "Silent install", _ => silentInstall = true},

Copy link
Contributor Author

@kraenhansen kraenhansen Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll avoid showing the install GUI and starting the application (which is what I think might be causing some issues).

],
{
env: {
// See https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Setup/UpdateRunner.cpp#L173C40-L173C54
SQUIRREL_TEMP: sandboxPath,
},
}
);

const entry = queryRegistry();
assert(entry !== null, 'Expected an entry in the registry after installing');
Expand All @@ -84,6 +109,7 @@ export function installWindowsSetup({
const appExecutablePath = path.resolve(appPath, `${appName}.exe`);

// Check if the app executable exists after installing
debug('Using app executable path: %s', appExecutablePath);
assert(
fs.existsSync(appExecutablePath),
`Expected ${appExecutablePath} to exist`
Expand Down
Loading