Skip to content

Conversation

@myang1220
Copy link
Contributor

Description

Modify buttons to maintain consistency with standardization rules provided in MongoDB's docs. Change "Import data", "Add rule", "Analyze schema", and "Add stage" buttons. Change associated spec files' tests to match the label changes.
Screenshot 2025-06-23 at 1 23 29 PM
Screenshot 2025-06-23 at 1 23 32 PM
Screenshot 2025-06-23 at 1 23 34 PM
Screenshot 2025-06-23 at 1 23 38 PM

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings June 23, 2025 17:24
@myang1220 myang1220 requested a review from a team as a code owner June 23, 2025 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enforces consistent button labeling by switching the label casing to lowercase on key UI buttons according to MongoDB's design guidelines. It updates both component code and tests to reflect the new label format.

  • Changed "Analyze Schema" to "Analyze schema"
  • Changed "Add Rule" to "Add rule"
  • Changed "Import Data" to "Import data"
  • Changed "Add Stage" to "Add stage" in both component and test files

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/compass-schema/src/components/compass-schema.tsx Modified button label for schema analysis
packages/compass-schema-validation/src/components/validation-states.tsx Modified button label for adding rule
packages/compass-crud/src/components/document-list.tsx Modified button label for data import
packages/compass-aggregations/src/components/pipeline-builder-workspace/pipeline-builder-ui-workspace/index.spec.tsx Updated test expectation for stage addition
packages/compass-aggregations/src/components/add-stage/add-stage.tsx Modified button label for adding stage
packages/compass-aggregations/src/components/add-stage/add-stage.spec.tsx Updated test expectations for stage label

@github-actions github-actions bot added the fix label Jun 23, 2025
@Anemy Anemy added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Jun 23, 2025
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! First Compass pr 🎉

@myang1220 myang1220 merged commit 2c046e2 into main Jun 23, 2025
58 of 61 checks passed
@myang1220 myang1220 deleted the standardized-button-capitalization branch June 23, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants