Skip to content

fix(compass): keep button labeling consistent w/ lowercase #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(compass): keep button labeling consistent w/ lowercase #7050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 17 additions & 34 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/compass-aggregations/src/components/add-stage/add-stage.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('AddStage', function () {
renderAddStage({ variant: 'icon' });
const button = screen.getByTestId('add-stage-icon-button');
expect(() => {
within(button).getByText('Add Stage');
within(button).getByText('Add stage');
}).to.throw;
});

Expand All @@ -41,7 +41,7 @@ describe('AddStage', function () {
it('renders text button', function () {
renderAddStage({ variant: 'button' });
const button = screen.getByTestId('add-stage');
expect(within(button).getByText('Add Stage')).to.exist;
expect(within(button).getByText('Add stage')).to.exist;
});

it('renders help link when stage is not last', function () {
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-aggregations/src/components/add-stage/add-stage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const AddStage = ({ onAddStage, variant }: AddStageProps) => {
variant="primary"
leftGlyph={<Icon glyph="Plus"></Icon>}
>
Add Stage
Add stage
</Button>

<div className={linkContainerStyles}>
Expand Down
4 changes: 2 additions & 2 deletions ...ns/src/components/pipeline-builder-workspace/pipeline-builder-ui-workspace/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('PipelineBuilderUIWorkspace [Component]', function () {
await renderPipelineBuilderUIWorkspace();
const buttons = screen.getAllByTestId('add-stage');
expect(buttons.length).to.equal(1);
expect(buttons[0]).to.have.text('Add Stage');
expect(buttons[0]).to.have.text('Add stage');
});

it('adds a stage to the start of pipeline when first icon button is clicked', async function () {
Expand Down Expand Up @@ -95,7 +95,7 @@ describe('PipelineBuilderUIWorkspace [Component]', function () {
await renderPipelineBuilderUIWorkspace({}, { pipeline: [] });
const button = screen.getByTestId('add-stage');
expect(button).to.exist;
expect(button).to.have.text('Add Stage');
expect(button).to.have.text('Add stage');
});

it('adds a stage when (text) button is clicked', async function () {
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-crud/src/components/document-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ const DocumentList: React.FunctionComponent<DocumentListProps> = (props) => {
variant="primary"
size="small"
>
Import Data
Import data
</Button>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-schema-validation/src/components/validation-states.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export function ValidationStates({
variant={ButtonVariant.PrimaryOutline}
size="small"
>
Add Rule
Add rule
</Button>
</div>
}
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-schema/src/components/compass-schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ const InitialScreen: React.FunctionComponent<{
variant="primary"
size="small"
>
Analyze Schema
Analyze schema
</Button>
}
callToActionLink={
Expand Down
Loading