Skip to content

chore(deps): update typescript to latest COMPASS-9531 #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 7, 2025
Merged

chore(deps): update typescript to latest COMPASS-9531 #7093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f4f0d66
chore(deps): update typescript to latest
gribnoysup Jul 4, 2025
bab6e5b
chore(scripts): add preset for typescript updates
gribnoysup Jul 4, 2025
9562ae4
fix(typescript): resolve a bunch of instances of TS2742: The inferred…
gribnoysup Jul 4, 2025
2d8b840
fix(compass-main): deal with misc module resolution issues
gribnoysup Jul 4, 2025
0f9e525
fix(settings): fix use before define by removing unused variable
gribnoysup Jul 4, 2025
42d1aba
Merge branch 'main' into update-typescript-to-latest
gribnoysup Jul 4, 2025
693d153
fix(query-bar): do not allow to clone the placeholder DOM to make sur…
gribnoysup Jul 7, 2025
e5d4079
Merge branch 'main' into update-typescript-to-latest
gribnoysup Jul 7, 2025
2ccd8b7
chore(query-bar): better fix for codemirror placeholder issue
gribnoysup Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/mocha-config-compass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"identity-obj-proxy": "^3.0.0",
"react-16-node-hanging-test-fix": "^1.0.0",
"sinon-chai": "^3.7.0",
"ts-node": "^10.9.1",
"ts-node": "^10.9.2",
"why-is-node-running": "^2.2.2"
}
}
2 changes: 1 addition & 1 deletion configs/testing-library-compass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"depcheck": "^1.4.1",
"mocha": "^10.2.0",
"nyc": "^15.1.0",
"typescript": "^5.0.4"
"typescript": "^5.8.3"
},
"dependencies": {
"@testing-library/react": "^12.1.5",
Expand Down
10 changes: 9 additions & 1 deletion configs/testing-library-compass/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,9 @@ function createWrapper(
const wrapperState = {
globalAppRegistry: new AppRegistry(),
localAppRegistry: new AppRegistry(),
preferences: new InMemoryPreferencesAccess(options.preferences),
preferences: new InMemoryPreferencesAccess(
options.preferences
) as PreferencesAccess,
Comment on lines +286 to +288
Copy link
Collaborator Author

@gribnoysup gribnoysup Jul 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all those TS2742 cases, sometimes it was easier (and better, we don't actually want these types to escape module boundaries in most cases) to make sure that internal interfaces are not leaking

track: Sinon.stub(),
logger: createNoopLogger(),
connectionStorage:
Expand Down Expand Up @@ -585,6 +587,12 @@ function createPluginWrapper<
return { ref, Wrapper: ComponentWithProvider };
}

export type RenderPluginWithConnectionsResult<
T extends CompassPluginComponent<any, any, any>
> = RenderWithConnectionsResult & {
plugin: ReturnType<T['useActivate']>;
};

function createPluginTestHelpers<
Props,
ServiceLocators extends Record<string, () => unknown>,
Expand Down
2 changes: 1 addition & 1 deletion configs/tsconfig-compass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"tsconfig.react.json"
],
"peerDependencies": {
"typescript": "^5.0.4"
"typescript": "^5.8.3"
},
"devDependencies": {
"@mongodb-js/prettier-config-compass": "^1.2.8"
Expand Down
3 changes: 2 additions & 1 deletion configs/tsconfig-compass/tsconfig.common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"removeComments": false,
"moduleResolution": "node16"
"moduleResolution": "node16",
"module": "node16"
}
}
4 changes: 3 additions & 1 deletion configs/tsconfig-compass/tsconfig.react.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.react.json",
"compilerOptions": {
"removeComments": false
"removeComments": false,
"moduleResolution": "node16",
"module": "node16"
}
}
2 changes: 1 addition & 1 deletion configs/webpack-config-compass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@types/html-webpack-plugin": "^3.2.9",
"@types/webpack-bundle-analyzer": "^4.7.0",
"depcheck": "^1.4.1",
"typescript": "^5.0.4"
"typescript": "^5.8.3"
},
"dependencies": {
"@babel/core": "^7.21.4",
Expand Down
Loading