chore(deps): update typescript to latest COMPASS-9531 #7093
Conversation
| "module": "nodenext", | ||
| "moduleResolution": "nodenext" |
There was a problem hiding this comment.
For now was easier to keep everything else on node16 and only switch e2e to nodenext, I think in theory we might want to use this module config option everywhere (or rather a combination of this and bundler), but I didn't want to deal with implications in this PR
… type cannot be named without internal reference
gribnoysup
force-pushed
the
update-typescript-to-latest
branch
from
a6433f4 to
0f9e525
Compare
| preferences: new InMemoryPreferencesAccess( | ||
| options.preferences | ||
| ) as PreferencesAccess, |
There was a problem hiding this comment.
For all those TS2742 cases, sometimes it was easier (and better, we don't actually want these types to escape module boundaries in most cases) to make sure that internal interfaces are not leaking
| ...args: Parameters<typeof configureStore> | ||
| ) { | ||
| ): Promise< | ||
| RenderPluginWithConnectionsResult<typeof CompassAggregationsPlugin.provider> |
There was a problem hiding this comment.
... and sometimes I only managed to make it work by explicitly re-annotating fuctions as the error text suggests doing (which is also not bad, but in some cases was caused by some annoying type resolution quirks rather than real issues)
…e that event listeners stay attached
| }; | ||
|
|
||
| // @ts-expect-error typescript is correctly highlighting that this esm import | ||
| // is missing a path, but we're passing this through bundler, so that's kinda |
There was a problem hiding this comment.
| // is missing a path, but we're passing this through bundler, so that's kinda | |
| // is missing an extension in the path, but we're passing this through bundler, so that's kinda |
|
Seems like we lost all macos14-arm hosts and so the ci is stuck, will merge as everything else is passing |
Now that eslint and (more importantly) typescript-eslint is up to date we can update typescript to latest finally. This was also in the way of POC for @mongodb-js/ts-autocomplete integration in compass (package is on latest typescript causing verison bump for the whole monorepo causing a buch of issues to pop up). This could be worked around, but it's also good to be on latest version
First two commit are just the version bump, all the required fixes are in their own commits to make it a bit easier to review this