Skip to content

chore(deps): update typescript to latest COMPASS-9531 #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 7, 2025
Merged

chore(deps): update typescript to latest COMPASS-9531 #7093

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f4f0d66
chore(deps): update typescript to latest
gribnoysup Jul 4, 2025
bab6e5b
chore(scripts): add preset for typescript updates
gribnoysup Jul 4, 2025
9562ae4
fix(typescript): resolve a bunch of instances of TS2742: The inferred…
gribnoysup Jul 4, 2025
2d8b840
fix(compass-main): deal with misc module resolution issues
gribnoysup Jul 4, 2025
0f9e525
fix(settings): fix use before define by removing unused variable
gribnoysup Jul 4, 2025
42d1aba
Merge branch 'main' into update-typescript-to-latest
gribnoysup Jul 4, 2025
693d153
fix(query-bar): do not allow to clone the placeholder DOM to make sur…
gribnoysup Jul 7, 2025
e5d4079
Merge branch 'main' into update-typescript-to-latest
gribnoysup Jul 7, 2025
2ccd8b7
chore(query-bar): better fix for codemirror placeholder issue
gribnoysup Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/compass/src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ async function main(): Promise<void> {
trackingProps: { context: 'CLI' },
};

// @ts-expect-error typescript is correctly highlighting that this esm import
// is missing a path, but we're passing this through bundler, so that's kinda
Copy link
Collaborator Author

@gribnoysup gribnoysup Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// is missing a path, but we're passing this through bundler, so that's kinda
// is missing an extension in the path, but we're passing this through bundler, so that's kinda

// expected. In theory we should switch tsconfing to moduleResolution: bundler
// to fix this, on practice switching to anything that prefers esm over cjs
// causes a lot of code to stop compiling because types are not being resolved
// correctly, so we're just ignoring this error for now
const { CompassApplication } = await import('./application');

const doImportExport =
Expand Down
3 changes: 2 additions & 1 deletion packages/compass/src/main/protocol-handling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ import type { PreferencesAccess } from 'compass-preferences-model';
const { log, mongoLogId } = createLogger('COMPASS-MAIN');

type ProtocolsList = { name: string; schemes: string[] }[];

async function appProtocolsConfig(): Promise<ProtocolsList> {
return (await import('../../package.json')).config.hadron.protocols;
return (await import('../../package.json')).default.config.hadron.protocols;
}

const commandArgv = process.defaultApp
Expand Down
7 changes: 7 additions & 0 deletions packages/compass/src/main/window-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,13 @@ async function onAppReady() {
'electron-devtools-installer'
);
try {
// @ts-expect-error typescript is right and default export from
// electron-devtools-installer is not a function, but because we're
// passing this code through the bundler it all works fine. In theory we
// should switch tsconfing to moduleResolution: bundler to fix this, on
// practice switching to anything that prefers esm over cjs causes a lot
// of code to stop compiling because types are not being resolved
// correctly, so we're just ignoring this error for now
await installDevtools(REACT_DEVELOPER_TOOLS);
} catch {
// noop
Expand Down