Skip to content

feat: vendor LG drawer and toolbar COMPASS-9406 #7120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 18, 2025
Merged

feat: vendor LG drawer and toolbar COMPASS-9406 #7120

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb382b0
wip
paula-stacho Jul 16, 2025
7cbec62
use drawer
paula-stacho Jul 17, 2025
2892143
style
paula-stacho Jul 17, 2025
9895a39
cleanup
paula-stacho Jul 17, 2025
33f83f6
git config core.ignorecase false
paula-stacho Jul 17, 2025
ebe9694
cleaning up git
paula-stacho Jul 17, 2025
e1fa901
revert data modeling changes
paula-stacho Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 198 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/compass-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,15 @@
"@leafygreen-ui/code": "^16.0.2",
"@leafygreen-ui/combobox": "^11.0.2",
"@leafygreen-ui/confirmation-modal": "^6.0.2",
"@leafygreen-ui/descendants": "^2.1.0",
"@leafygreen-ui/emotion": "^4.0.9",
"@leafygreen-ui/guide-cue": "^7.0.2",
"@leafygreen-ui/hooks": "^8.3.4",
"@leafygreen-ui/icon": "^13.1.2",
"@leafygreen-ui/icon-button": "16.0.2",
"@leafygreen-ui/info-sprinkle": "^4.0.2",
"@leafygreen-ui/leafygreen-provider": "^4.0.2",
"@leafygreen-ui/lib": "^15.2.0",
Copy link
Collaborator

@gribnoysup gribnoysup Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have two versions of lib package in compass-components, 14 and 15. Is it required to pull this dependency here at this exact version? If not, it would be better if we can keep it aligned

Copy link
Collaborator

@gribnoysup gribnoysup Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looking closer and I think it is already somewhat of an issue due to diagramming package pulling its own leafygreen deps (not only lib, but a bunch of others too):

└─┬ @mongodb-js/[email protected] -> ./packages/compass-data-modeling
  └─┬ @mongodb-js/[email protected]
    ├─┬ @leafygreen-ui/[email protected]
    │ ├─┬ @leafygreen-ui/[email protected]
    │ │ └── @leafygreen-ui/[email protected] deduped
    │ └── @leafygreen-ui/[email protected]
    └─┬ @leafygreen-ui/[email protected]
      └── @leafygreen-ui/[email protected] deduped

... so if it's easier to keep like that for your patch, that is fine. We might need to deal with this later though, but it can wait

Copy link
Collaborator Author

@paula-stacho paula-stacho Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vendored packages call it directly, v14 doesn't work for them. I'm hoping we'll do the proper upgrade soon, and for the direct dependency here we'll be reminded by depcheck to clean this up. If we really want to avoid this I think we'd just need to avoid all the new lg-id bits.

Copy link
Collaborator

@gribnoysup gribnoysup Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, that's fair, yeah

"@leafygreen-ui/logo": "^10.0.2",
"@leafygreen-ui/marketing-modal": "^5.0.2",
"@leafygreen-ui/menu": "^29.0.5",
Expand Down
2 changes: 2 additions & 0 deletions packages/compass-components/src/components/drawer/Drawer/Drawer.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export const HEADER_HEIGHT = 48;
export const MOBILE_BREAKPOINT = 390;
Loading
Loading