Skip to content

Conversation

@nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Jul 17, 2025

Description

Finishing the job done for the rest of compass

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings July 17, 2025 13:53
@nbbeeken nbbeeken requested a review from a team as a code owner July 17, 2025 13:53
@github-actions github-actions bot added the fix label Jul 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a configuration option to skip ping operations during MongoDB client connection specifically for the compass-web package. This continues work done for other parts of the Compass application to optimize connection behavior.

  • Adds __skipPingOnConnect = true to MongoDB client options in the compass-web polyfill
Comments suppressed due to low confidence (1)

packages/compass-web/polyfills/@mongodb-js/devtools-connect/index.ts:18

  • The option name uses double underscores (__skipPingOnConnect) which typically indicates a private/internal API. Consider verifying this is the correct option name for the MongoDB driver version being used, as private APIs may change between versions.
  options.__skipPingOnConnect = true;

@nbbeeken nbbeeken added the no release notes Fix or feature not for release notes label Jul 17, 2025
@nbbeeken nbbeeken merged commit a9b2fa7 into main Jul 17, 2025
57 of 60 checks passed
@nbbeeken nbbeeken deleted the COMPASS-9579 branch July 17, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants